Return 400 for invalid task JSON (#19)

Author: Autowebassat-blip

apps/commandboard-api/src/contract.test.ts

@@ -39,6 +39,20 @@ describe("CommandBoard API contracts", () => {
     expect(body).toEqual({ ok: true, service: "commandboard-api" });
   });
 
+
+
+  it("rejects malformed task JSON with a client error", async () => {
+    const response = await fetch(`${baseUrl}/api/tasks`, {
+      method: "POST",
+      headers: { "content-type": "application/json" },
+      body: "{not-json"
+    });
+    const body = await response.json() as { error: string };
+
+    expect(response.status).toBe(400);
+    expect(body).toEqual({ error: "Invalid JSON body" });
+  });
+
   it("exposes default plugin contract including product plugins", async () => {
     const response = await fetch(`${baseUrl}/api/plugins`);
     const body = await response.json() as {

apps/commandboard-api/src/index.ts

@@ -104,7 +104,14 @@ async function route(request: IncomingMessage, response: ServerResponse) {
   }
 
   if (request.method === "POST" && url.pathname === "/api/tasks") {
-    const body = await readJson(request);
+    let body: unknown;
+    try {
+      body = await readJson(request);
+    } catch {
+      json(response, 400, { error: "Invalid JSON body" });
+      return;
+    }
+
     const result = validate("task", body);
     if (!result.ok) {
       json(response, 422, { errors: result.errors });