Merge pull request #8193 from processing/fix/filter-size

Fix filters on framebuffers of a different size than the canvas

Author: davepagurek

src/webgl/p5.RendererGL.js

@@ -1352,8 +1352,8 @@ class RendererGL extends Renderer {
       fbo,
       0,
       0,
-      this.width,
-      this.height,
+      fbo.width,
+      fbo.height,
       -target.width / 2,
       -target.height / 2,
       target.width,

test/unit/visual/cases/webgl.js

@@ -51,6 +51,20 @@ visualSuite('WebGL', function() {
       screenshot();
     });
 
+    visualTest('On a framebuffer of a different size from the canvas', function(p5, screenshot) {
+      p5.createCanvas(50, 50, p5.WEBGL);
+      const fbo = p5.createFramebuffer({ antialias: true, width: 25, height: 100 });
+      fbo.begin();
+      p5.background('blue');
+      p5.fill('red');
+      p5.circle(0, 0, 20);
+      p5.filter(p5.BLUR, 3);
+      fbo.end();
+      p5.imageMode(p5.CENTER);
+      p5.image(fbo, 0, 0);
+      screenshot();
+    });
+
     visualTest(
       'On a framebuffer sized differently from the main canvas',
       function(p5, screenshot) {

test/unit/visual/screenshots/WebGL/filter/On a framebuffer of a different size from the canvas/000.png

@@ -0,0 +1,3 @@
+{
+  "numScreenshots": 1
+}