Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Workflow Spends Over 20 Minutes on File Compression #647

Open
SableRaf opened this issue Dec 2, 2024 · 1 comment
Open

Build Workflow Spends Over 20 Minutes on File Compression #647

SableRaf opened this issue Dec 2, 2024 · 1 comment
Labels
Enhancement New feature or request

Comments

@SableRaf
Copy link
Contributor

SableRaf commented Dec 2, 2024

The p5.js website build workflow takes over 20 minutes, with significant time spent on the compression step (labelled AstroCompress processing in the logs) for html, images, and other files. This duration impacts the developer experience and considerably slows down iterations during development.

See for example: GitHub Action Log

Relevant issues in the repository for Astro's compression library:

  1. [performance] Compress in parallel #54 (Help Wanted)
  2. Cache #49 (Help Wanted)

Suggestions

  • Consider contributing to the upstream fixes in the Astro compression library.
@SableRaf SableRaf added the Enhancement New feature or request label Dec 2, 2024
@limzykenneth
Copy link
Member

#615 will fix this to a certain extend, I still need to fix some bugs though.

However, npm run build is not meant to be run in the dev environment. npm run dev should suffice for development preview and provides much better dev experience. If there are any notable difference between dev preview and full build it should be considered a bug with the build/dev system and fixed accordingly without need to use npm run build in local environment.

Only CI should run npm run build which will still be slow until Astro can improve parallelization on their end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants