Merge pull request #3699 from clairep94/add_typecheck_to_ci

pr05: Add typecheck to ci

Author: raclim

.github/workflows/test.yml

@@ -7,13 +7,12 @@ jobs:
     name: Test and lint code base
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
-    - name: Use Node.js
-      uses: actions/setup-node@v1
-      with:
-        node-version: '18.20.x'
-    - run: npm install
-    - run: npm run test
-    - run: npm run lint
-
-
+      - uses: actions/checkout@v2
+      - name: Use Node.js
+        uses: actions/setup-node@v1
+        with:
+          node-version: '18.20.x'
+      - run: npm install
+      - run: npm run test
+      - run: npm run typecheck
+      - run: npm run lint

server/routes/passport.routes.ts

@@ -1,5 +1,6 @@
 import { Router, Request, Response, NextFunction } from 'express';
 import passport from 'passport';
+import { UserDocument } from '../types';
 
 const router = Router();
 
@@ -11,7 +12,7 @@ const authenticateOAuth = (service: string) => (
   passport.authenticate(
     service,
     { failureRedirect: '/login' },
-    (err: unknown, user: unknown) => {
+    (err: unknown, user: UserDocument) => {
       if (err) {
         // use query string param to show error;
         res.redirect(`/account?error=${service}`);