Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behavior with binaries path #13

Open
krumware opened this issue Oct 4, 2023 · 3 comments
Open

Unexpected behavior with binaries path #13

krumware opened this issue Oct 4, 2023 · 3 comments

Comments

@krumware
Copy link

krumware commented Oct 4, 2023

The default binaries path looks to not be detecting OS

krumware@PF-3842ND:~/code/privateerproj/cli$ ./privateer.exe list -a
2023/10/04 13:56:49 open \\wsl.localhost\Ubuntu\home\krumware\code\privateerproj\cli\config.yml: The system cannot find the file specified.
No raids present in the binaries path: C:\Users\colin/privateer/bin
@eddie-knight
Copy link
Contributor

Right now my best guess is that this is something related to WSL when we're combining os and path 🤔 Perhaps it's getting the OS as windows in os.UserHomeDir, then it's seeing WSL for the path.Join

func defaultBinariesPath() string {
	home, _ := os.UserHomeDir() // sue me
	return path.Join(home, "privateer", "bin")
}

ref:
https://github.com/privateerproj/privateer/blob/main/cmd/root.go#L60-L63

@krumware
Copy link
Author

krumware commented Oct 9, 2023

There's probably a portion of this which could be WSL wonkyness from running that .exe in the WSL/Ubuntu instantce

@eddie-knight
Copy link
Contributor

Let's circle back to this when we have goreleaser fixed. I'll squeeze some time this week to dig into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants