Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perspective bilinear warps are not drawn in the correct location when reloading warps #5

Open
BenBergman opened this issue Jul 11, 2019 · 2 comments

Comments

@BenBergman
Copy link

When loading warp info from a json file, the warp texture is drawn beyond the boundaries defined by the warp handles. This can be demonstrated by deleting the json file for the example, positioning all the warps, quiting the app, then re-running the app. The resulting drawn warp is about 100% too wide and 50% too tall.
Screen Shot 2019-07-11 at 14 21 25 PM

@BenBergman
Copy link
Author

This might be even weirder than I originally thought (or maybe this is unrelated). I've noticed with a bilinear warp that the internal resolution of the warp is lower when loading a settings json. See the below screen shots. The first is when loaded with no settings file. Saving the warp (ie. control points in the corners of the screen) and loading the app again, the grahpics are much more blurry/chunky and drawing a circle shows it stretched out (the text is drawn from a video to fill the warp bounds).

Screen Shot 2019-07-11 at 15 33 27 PM

Screen Shot 2019-07-11 at 15 33 51 PM

@BenBergman
Copy link
Author

I found a fix that fixes both issues. PR incoming shortly.

BenBergman added a commit to BenBergman/ofxWarp that referenced this issue Jul 11, 2019
This is a fix for the issues noted in prisonerjohn#5.
@BenBergman BenBergman changed the title Perspective bilinear warps are not drown in the correct location when reloading warps Perspective bilinear warps are not drawn in the correct location when reloading warps Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant