Issue with Prisma binding

[marktani]

@OGNeutron commented on Fri May 11 2018

When I graphql-prepare I am getting a type issue with Prisma in prisma.ts

Property 'query' in type 'Prisma' is not assignable to the same property in base type 'Prisma'.
  Type 'Query' is not assignable to type 'QueryMap'

---

@marktani commented on Fri May 11 2018

Please share a minimal reproduction so we can look into this 🙂

---

@OGNeutron commented on Fri May 11 2018

Alright, I just do the normal prisma deploy, the database sets up fine and even the post hooks show fine:

post-deploy:
Running graphql get-schema --project db √
Running graphql prepare √

But they don't actually generate the files, so I do it manually and it shows up, but than I get that issue with the prisma.ts file where all three, query, mutation and subscriptions give similar errors.

[ts]
Property 'mutation' in type 'Prisma' is not assignable to the same property in base type 'Prisma'.
  Type 'Mutation' is not assignable to type 'QueryMap'.
    Property 'createNotification' is incompatible with index signature.
      Type '(args: { data: NotificationCreateInput; }, info?: string | GraphQLResolveInfo) => Promise<Notific...' is not assignable to type '(args?: { [key: string]: any; }, context?: { [key: string]: any; }, info?: string | GraphQLResolv...'.
        Types of parameters 'info' and 'context' are incompatible.
          Type '{ [key: string]: any; }' is not assignable to type 'string | GraphQLResolveInfo'.
            Type '{ [key: string]: any; }' is not assignable to type 'GraphQLResolveInfo'.

https://github.com/OGNeutron/Prisma_main_hub

[abelovic]

I am getting this as well... the post deploy hooks don't seem to work :(

If I run in a script: "prisma deploy && graphql get-schema && graphql prepare" it generates the file as expected

[timsuchanek]

Thanks for reporting! prisma-binding@2 is not meant to be used with graphql prepare, but graphql codegen. My apologies if we didn't communicate that clearly.
To make graphql codegen possible, you also need to configure your .graphqlconfig.yml.
Here is an example of a running project that uses graphql codegen together with the new prisma-binding@2:
https://github.com/graphql-binding/graphql-binding/tree/master/examples/full-example

I let this issue open as a reminder for us to create better docs.

Would be cool to get your feedback @marktani & @abelovic if switching to graphql codegen works in your use case.

[NeutronScott12]

Alright might need a slight guide on how to implement this because the example is a bit different to mine, I copied the part of the graphqlconfig.yml relevant to Prisma, but it doesn't seem to generate now with graphql get-schema or graphql codegen but runs fine without errors.

https://github.com/OGNeutron/Prisma_main_hub

[abelovic]

@timsuchanek - I am having trouble getting this to work as well using the graphql boilerplates structure that most of us are using. Here is my graphqlconfig:

When I run the following config I get: "Couldn’t find prisma.yml file. Are you in the right directory?" Not sure why I am getting this when I have set the path :/

  app:
    schemaPath: src/schema.graphql
    extensions:
      endpoints:
        default: http://localhost:4000
  db: #Is this supposed to be "db" or "database" - was database before? I tried both btw
    schemaPath: src/generated/prisma.graphql
    extensions:
      prisma: database/prisma.yml
      codegen:
       generator: prisma-binding
         language: javascript
         input: schema.js #What is this? Are we supposed to add this file? Is this because you are not running import-loader package in your example?
         output:
           binding: src/generated/prisma.js

[abelovic]

Running this doesn't give the error but doesn't generate the file either which I think is what @OGNeutron is running into as well:

  app:
    schemaPath: src/schema.graphql
    extensions:
      endpoints:
        default: http://localhost:4000
  database:
    schemaPath: src/generated/prisma.graphql
    extensions:
      prisma: database/prisma.yml
      codegen:
        - generator: prisma-binding
          language: javascript
          input: src/generated/prisma.graphql
          output:
            binding: src/generated/prisma.js

[steve-a-jones]

Running into similar errors .. Type '{}' is not assignable to type 'GraphQLResolveInfo'. Property 'fieldName' is missing in type '{}'... etc..

Would also love some clarity and better documentation around these configs... they are fairly esoteric and difficult to reason about. I would almost rather just have a few scripts to imperatively generate everything instead :)

[NeutronScott12]

Still haven't got it working with my current project, also not getting any errors or generated files, I tried different setups, I can get graphql get-schema working, but codegen just runs and shows nothing.

[SpaceK33z]

These docs are also out of date now. I'd help update the docs except I don't understand how prisma-binding@2 works at all.

[abelovic]

The whole 1.8 release seems too rushed considering there are so many breaking changes. This has caused so many problems for me. I pay for the prisma cloud and the whole point of this is so I can forget about it and it just works. This has been far from the truth. This is now consuming 90% of my time because it seems like every time I upgrade something breaks. Since this is the DAL/ORM (or whatever you want to call it) it basically cripples my app development until I can resolve it :( The prisma team needs to consider doing pre-releases and properly test/document this stuff before releasing to the masses. I do not want to pay to be a beta tester for prisma.

[alvis]

I'm feeling the same. Breaking changes are fine, but you need documentation! At least the team should give us a migration guide for anything changed. Spending 90% of my time to trace what's breaking is breaking my heart to Prisma.