Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageLayout doesn't extend the sidebar divider when extending the height. #4351

Open
maximedegreve opened this issue Mar 4, 2024 · 3 comments

Comments

@maximedegreve
Copy link
Contributor

maximedegreve commented Mar 4, 2024

Description

On GitHub, I've seen some pages using the PageLayout component, but there's a problem: when you can't scroll, the PageLayout doesn't stretch to fill the whole page, which means the divider ends up getting cut off halfway down the page. To fix this, I tried making the PageLayout fill up all the available space from its parent in a few instances, but this didn't solve the issue – the divider still gets cut off.

Code snippet showing the divider line not expanding

💬 Related internal conversation

Steps to reproduce

Check my CodeSandbox

Version

Latest

Browser

Safari

Copy link
Contributor

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

@CleverLemming1337
Copy link

I could fix your issue by adding height: '100vh' in line 46 of your code.

@AbhinavKumarjss
Copy link

Hey Can i work on this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants