Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ’„Style: ๋„์„œ/CD ๋ฆฌ์ŠคํŠธ ์ปดํฌ๋„ŒํŠธ ์Šคํƒ€์ผ๋ง #16

Merged
merged 4 commits into from
Feb 16, 2025
Merged

๐Ÿ’„Style: ๋„์„œ/CD ๋ฆฌ์ŠคํŠธ ์ปดํฌ๋„ŒํŠธ ์Šคํƒ€์ผ๋ง #16

merged 4 commits into from
Feb 16, 2025

Conversation

Hyuunw00
Copy link
Collaborator

@Hyuunw00 Hyuunw00 commented Feb 15, 2025 •
edited
Loading

โœจ ๋ฐ˜์˜ ๋ธŒ๋žœ์น˜

style/datalist-component -> dev

๐Ÿ“ ์„ค๋ช…

๋„์„œ/CD ๋ฆฌ์ŠคํŠธ์— ์‚ฌ์šฉ๋˜๋Š” ๊ณตํ†ต ์ปดํฌ๋„ŒํŠธ ์Šคํƒ€์ผ๋ง

โœ… ๋ณ€๊ฒฝ ์‚ฌํ•ญ

  • cd, cdcase ์ปดํฌ๋„ŒํŠธ ์ถ”๊ฐ€ ๋ฐ ๋ผ์šฐํŠธ์— ๋ฐ˜์˜๏ฟฝ
  • classnames ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ ์ถ”๊ฐ€
  • types ํด๋” ์ƒ์„ฑํ›„ datalist ์ปดํฌ๋„ŒํŠธ์— ๋“ค์–ด๊ฐˆ ํƒ€์ž… ์„ ์–ธ
  • components /datalist ํด๋”์— ์Šคํƒ€์ผ๋งํ•œ ๊ณตํ†ต ์ปดํฌ๋„ŒํŠธ ์ถ”๊ฐ€

๐Ÿ’ฌ PR ํฌ์ธํŠธ & ์งˆ๋ฌธ์‚ฌํ•ญ

์ปดํฌ๋„ŒํŠธ ์‚ฌ์šฉ ๋ฐฉ๋ฒ•

  • type์— book ๋˜๋Š” cd ๋„ฃ๊ธฐ
  • datas์— ์ •์ œ๋œ ๋ฐ์ดํ„ฐ( title, author? , singer?, released_year, publisher?)
    image

CD

image

๋„์„œ

image

๋„์„œ ํŽธ์ง‘์‹œ

image

๐Ÿ“ข ์ด์Šˆ ์ •๋ณด

[์ด์Šˆ ๋ฒˆํ˜ธ/์ •๋ณด](์ด์Šˆ url)

@Hyuunw00 Hyuunw00 linked an issue Feb 15, 2025 that may be closed by this pull request
style/editList #4
Closed
miseullang
miseullang approved these changes Feb 16, 2025
View reviewed changes
Copy link
Collaborator

@miseullang miseullang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•„์ด์ฝ˜๋“ค ๊ฐ๊ฐ book์ด๋ž‘ cd์ชฝ์— ๋„ฃ์–ด๋†จ์—ˆ๋Š”๋ฐ ํ™•์‹คํžˆ ์–ด๋””์— ๋ญ๊ฐ€ ์žˆ๋Š”์ง€ ์ฐพ๊ธฐ ์–ด๋ ต๊ฒ ๋„ค์š”... ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

@miseullang miseullang merged commit 1017260 into dev Feb 16, 2025
@miseullang miseullang deleted the 4-styleeditlist branch February 16, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miseullang miseullang miseullang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

style/editList
2 participants
@Hyuunw00 @miseullang