Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pullrequests: view html 기능개발 #84

Merged
merged 13 commits into from
Oct 7, 2024
Merged

pullrequests: view html 기능개발 #84

merged 13 commits into from
Oct 7, 2024

Conversation

jungyoeal
Copy link
Collaborator

#83

#️⃣연관된 이슈

☑️ PR 유형

  • 새로운 기능 추가
  • 버그 수정
  • 문서 수정
  • 코드에 영향을 주지 않는 변경사항(오타 수정, 탭 사이즈 변경, 변수명 변경)
  • 코드 리팩토링
  • 테스트 추가, 테스트 리팩토링
  • 빌드 부분 혹은 패키지 매니저 수정
  • 주석 추가 및 수정
  • 파일 혹은 폴더 삭제
  • 파일 혹은 폴더명 수정
  • CSS 등 사용자 UI 디자인 변경

📝 작업 내용

html commit
타임리프 작업

✅ 피드백 반영사항

💬 리뷰 요구사항

jungyoeal and others added 13 commits September 27, 2024 11:40
@jungyoeal
엔티티 수정만함 이외 서비스는 제외
69a710b
@juwon-code @jungyoeal
rename: 프로젝트 패키지 구조 변경
96ceac2 
혼동되는 패키지가 있어서 수정합니다.

- xenum -> 각 도메인의 entity로 이동
- security 패키지를 삭제하고, token과 global 패키지로 분리
- global/exception -> 각 도메인의 exception으로 이동
@ghtndl @jungyoeal
user entity modified
da4239c
@Preta3418 @jungyoeal
service
149dd97
@jungyoeal
.
5968317
@jungyoeal
Merge remote-tracking branch 'refs/remotes/origin/main' into dev/feat…
72c9785 
…/html/#12
@jungyoeal
Merge remote-tracking branch 'refs/remotes/origin/main' into dev/feat…
45c6302 
…/html/#12
@jungyoeal
Merge remote-tracking branch 'refs/remotes/origin/main' into dev/feat…
710d42b 
…/html/#12
@jungyoeal
Merge remote-tracking branch 'refs/remotes/origin/main' into dev/feat…
711fc76 
…/html/#12

# Conflicts:
#	src/main/java/com/prgrms2/java/bitta/member/entity/CustomMemberPrincipal.java
@jungyoeal
Merge remote-tracking branch 'refs/remotes/origin/main' into dev/feat…
4c308f4 
…/html/#12

# Conflicts:
#	src/main/resources/application.properties
@jungyoeal
html 추가 및 수정 본 기입함.
bff2cba
@jungyoeal
Merge remote-tracking branch 'refs/remotes/origin/main' into dev/feat…
293f2fa 
…/html/#12

# Conflicts:
#	src/main/resources/application.properties
@jungyoeal
feat: view 완료항목 게시
cee568b 
1. 컨트롤러 뷰는 버그로 뺌
2. 타임리프 엔티티 수정중
@jungyoeal jungyoeal linked an issue Oct 7, 2024 that may be closed by this pull request
feat : Html 뷰 작업 #83
Open
2 tasks
@jungyoeal jungyoeal requested review from juwon-code and ghtndl October 7, 2024 02:08
@jungyoeal jungyoeal changed the title Dev/feat/html#83 pullrequests: view html 기능개발 Oct 7, 2024
juwon-code
juwon-code approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@juwon-code juwon-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

프론트 작업 수고하셨습니다

@juwon-code juwon-code merged commit de1b382 into main Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juwon-code juwon-code juwon-code approved these changes

@ghtndl ghtndl Awaiting requested review from ghtndl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat : Html 뷰 작업
4 participants
@jungyoeal @juwon-code @ghtndl @Preta3418