Skip to content
This repository was archived by the owner on Oct 1, 2019. It is now read-only.

Validate all snapshots pass PEP8 #1

Open
azz opened this issue Dec 24, 2017 · 3 comments
Open

Validate all snapshots pass PEP8 #1

azz opened this issue Dec 24, 2017 · 3 comments

Comments

@azz
Copy link
Member

azz commented Dec 24, 2017

Could shell out to run https://pypi.python.org/pypi/pep8 on the stdin stream?

@taion
Copy link
Contributor

taion commented Dec 24, 2017

it’s pycodestyle now

y’all should talk to the @PyCQA folks, especially @sigmavirus24

@sigmavirus24
Copy link

@taion, please don't @-mention me unless it's required. I have far too many notifications to be subscribed to issues on which I have nothing to do. I don't appreciate being forcibly subscribed to things.

@taion
Copy link
Contributor

taion commented Dec 24, 2017

My bad. I see your name a lot on the Python code quality repos, so I thought you might find this interesting. Prettier has been a massive game changer in the JS ecosystem in ways that autopep8 and yapf have not been for Python.

ryanashcraft added a commit to ryanashcraft/plugin-python that referenced this issue Mar 4, 2018
Add optional PEP8_VALIDATE env flag for running prettier output from
tests into pycodestyle. If pycodestyle returns any errors, the test
fails.

Adds pycodestyle as a vendor dependency.

Several tests currently fail with the PEP8_VALIDATE flag enabled.

Proof of concept for prettier#1.
ryanashcraft added a commit to ryanashcraft/plugin-python that referenced this issue Mar 4, 2018
Add optional PEP8_VALIDATE env flag for running prettier output from
tests into pycodestyle. If pycodestyle returns any errors, the test
fails.

Adds pycodestyle as a vendor dependency.

Several tests currently fail with the PEP8_VALIDATE flag enabled.

Proof of concept for prettier#1.
ryanashcraft added a commit to ryanashcraft/plugin-python that referenced this issue Mar 4, 2018
Add optional PEP8_VALIDATE env flag for running prettier output from
tests into pycodestyle. If pycodestyle returns any errors, the test
fails.

Adds pycodestyle as a vendor dependency.

Several tests currently fail with the PEP8_VALIDATE flag enabled.

Proof of concept for prettier#1.
patrick91 pushed a commit that referenced this issue May 4, 2018
Add optional PEP8_VALIDATE env flag for running prettier output from
tests into pycodestyle. If pycodestyle returns any errors, the test
fails.

Adds pycodestyle as a vendor dependency.

Several tests currently fail with the PEP8_VALIDATE flag enabled.

Proof of concept for #1.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants