[native] Fix build order issues with presto_server

There is an issue where libraries were added after the final
presto_server target had already been created. That is, new libraries
were added after presto_server_lib was used to build to presto_server.
This means presto_server_lib might not have all expected symbols.

Author: czentgr

presto-native-execution/presto_cpp/main/CMakeLists.txt

@@ -96,33 +96,33 @@ target_link_libraries(
 target_link_libraries(presto_server_lib presto_thrift-cpp2 presto_thrift_extra
                       ${THRIFT_LIBRARY})
 
+if(PRESTO_ENABLE_REMOTE_FUNCTIONS)
+  add_library(presto_server_remote_function JsonSignatureParser.cpp
+                                            RemoteFunctionRegisterer.cpp)
+
+  target_link_libraries(presto_server_remote_function velox_expression
+                        velox_functions_remote ${FOLLY_WITH_DEPENDENCIES})
+  target_link_libraries(presto_server_lib presto_server_remote_function)
+endif()
+
 set_property(TARGET presto_server_lib PROPERTY JOB_POOL_LINK
                                                presto_link_job_pool)
 
 add_executable(presto_server PrestoMain.cpp)
 
-# Moving velox_hive_connector and velox_tpch_connector to presto_server_lib
-# results in multiple link errors similar to the one below only on GCC.
-# "undefined reference to `vtable for velox::connector::tpch::TpchTableHandle`"
-# TODO: Fix these errors.
-target_link_libraries(presto_server presto_server_lib velox_hive_connector
-                      velox_tpch_connector)
+# velox_tpch_connector is an OBJECT target in Velox and so needs to be linked
+# to the executable or use TARGET_OBJECT linkage for the presto_server_lib target.
+# However, we also would need to add its dependencies (tpch_gen etc).
+# TODO change the target in Velox to a library target then we can move this to the
+# presto_server_lib.
+target_link_libraries(presto_server presto_server_lib velox_tpch_connector)
 
 # Clang requires explicit linking with libatomic.
 if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang"
    AND "${CMAKE_CXX_COMPILER_VERSION}" VERSION_GREATER_EQUAL 15)
   target_link_libraries(presto_server atomic)
 endif()
 
-if(PRESTO_ENABLE_REMOTE_FUNCTIONS)
-  add_library(presto_server_remote_function JsonSignatureParser.cpp
-                                            RemoteFunctionRegisterer.cpp)
-
-  target_link_libraries(presto_server_remote_function velox_expression
-                        velox_functions_remote ${FOLLY_WITH_DEPENDENCIES})
-  target_link_libraries(presto_server_lib presto_server_remote_function)
-endif()
-
 set_property(TARGET presto_server PROPERTY JOB_POOL_LINK presto_link_job_pool)
 
 if(PRESTO_ENABLE_TESTING)