Skip to content

Commit b2d58e4

Browse files
fix(pixi_core): Fix logging panic by converting itertools::Format to string before passing to tracing (#4938)
1 parent 4aa99b2 commit b2d58e4

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

crates/pixi_core/src/activation.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,11 @@ pub fn get_activator<'p>(
128128
if !missing_scripts.is_empty() {
129129
tracing::warn!(
130130
"Could not find activation scripts: {}",
131-
missing_scripts.iter().map(|p| p.display()).format(", ")
131+
missing_scripts
132+
.iter()
133+
.map(|p| p.display())
134+
.format(", ")
135+
.to_string()
132136
);
133137
}
134138

crates/pixi_core/src/workspace/workspace_mut.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,11 @@ impl WorkspaceMut {
338338
affected_environments.contains(&self.workspace().default_environment());
339339
tracing::debug!(
340340
"environments affected by the add command: {}",
341-
affected_environments.iter().map(|e| e.name()).format(", ")
341+
affected_environments
342+
.iter()
343+
.map(|e| e.name())
344+
.format(", ")
345+
.to_string()
342346
);
343347
let affect_environment_and_platforms = affected_environments
344348
.into_iter()

0 commit comments

Comments
 (0)