Simple import handling for when flowslicer is installed as a package#1
Open
jprokos26 wants to merge 1 commit intopraxiseng:mainfrom
Open
Simple import handling for when flowslicer is installed as a package#1jprokos26 wants to merge 1 commit intopraxiseng:mainfrom
jprokos26 wants to merge 1 commit intopraxiseng:mainfrom
Conversation
Author
|
To clarify why I needed this change, I could not find an easy way to call flowslicer within BinaryNinja to view the output of calling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows
python -c “import flowslicer”to be run from either the local directory without any package installation (existing functionality) as well as supporting flowslicer to be installed as a package to be run anywhere (new functionality).This PR does not include the
setup.pyfile necessary for generating the package as I installed this as a submodule within a separate package usingsetuptools.find_packages(). See this example to see how I includedflowslicerwithin my ownsetup.py.Note, a better/clearer change would be to set up flowslicer to be a python package such that the
tryblock is unnecessary but I did not want this PR to change any existing functionality, only to add new.