add note for broken close call

Author: stevensJourney

lib/src/web/database.dart

@@ -212,6 +212,7 @@ class _ExclusiveTransactionContext extends _ExclusiveContext {
   @override
   Future<ResultSet> execute(String sql,
       [List<Object?> parameters = const []]) async {
+    // TODO offload this to a custom request for single round trip
     final isAutoCommit = await getAutoCommit();
     if (isAutoCommit && !sql.toLowerCase().contains('begin')) {
       throw SqliteException(0,
@@ -223,6 +224,7 @@ class _ExclusiveTransactionContext extends _ExclusiveContext {
   @override
   Future<void> executeBatch(
       String sql, List<List<Object?>> parameterSets) async {
+    // TODO offload this to a custom request for single round trip
     final isAutoCommit = await getAutoCommit();
     if (isAutoCommit && !sql.toLowerCase().contains('begin')) {
       throw SqliteException(0,

lib/src/web/database/web_sqlite_database.dart

@@ -21,6 +21,9 @@ class SqliteDatabaseImpl
     return _connection.closed;
   }
 
+  final StreamController<UpdateNotification> updatesController =
+      StreamController.broadcast();
+
   @override
   late Stream<UpdateNotification> updates;
 
@@ -68,13 +71,17 @@ class SqliteDatabaseImpl
   SqliteDatabaseImpl.withFactory(this.openFactory,
       {this.maxReaders = SqliteDatabase.defaultMaxReaders}) {
     mutex = MutexImpl();
+    // This way the `updates` member is available synchronously
+    updates = updatesController.stream;
     isInitialized = _init();
   }
 
   Future<void> _init() async {
     _connection = await openFactory.openConnection(SqliteOpenOptions(
         primaryConnection: true, readOnly: false, mutex: mutex));
-    updates = _connection.updates!;
+    _connection.updates!.forEach((update) {
+      updatesController.add(update);
+    });
   }
 
   T _runZoned<T>(T Function() callback, {required String debugContext}) {

lib/src/web/web_sqlite_open_factory.dart

@@ -7,7 +7,7 @@ import 'package:sqlite_async/src/web/web_mutex.dart';
 
 import 'database.dart';
 
-Map<SqliteOptions, WebSqlite> webSQLiteImplementations = {};
+Map<String, FutureOr<WebSqlite>> webSQLiteImplementations = {};
 
 /// Web implementation of [AbstractDefaultSqliteOpenFactory]
 class DefaultSqliteOpenFactory
@@ -20,15 +20,18 @@ class DefaultSqliteOpenFactory
       {required super.path,
       super.sqliteOptions = const SqliteOptions.defaults()})
       : _initialized = Future.sync(() {
-          if (webSQLiteImplementations.containsKey(sqliteOptions)) {
-            return webSQLiteImplementations[sqliteOptions]!;
+          final cacheKey = sqliteOptions.webSqliteOptions.wasmUri +
+              sqliteOptions.webSqliteOptions.workerUri;
+
+          if (webSQLiteImplementations.containsKey(cacheKey)) {
+            return webSQLiteImplementations[cacheKey]!;
           }
 
-          webSQLiteImplementations[sqliteOptions] = WebSqlite.open(
+          webSQLiteImplementations[cacheKey] = WebSqlite.open(
             wasmModule: Uri.parse(sqliteOptions.webSqliteOptions.wasmUri),
             worker: Uri.parse(sqliteOptions.webSqliteOptions.workerUri),
           );
-          return webSQLiteImplementations[sqliteOptions]!;
+          return webSQLiteImplementations[cacheKey]!;
         });
 
   @override

lib/src/web/worker/worker_utils.dart

@@ -1,5 +1,4 @@
 import 'dart:js_interop';
-import 'dart:js_interop_unsafe';
 
 import 'package:mutex/mutex.dart';
 import 'package:sqlite3/wasm.dart';
@@ -8,7 +7,7 @@ import 'package:sqlite_async/sqlite3_common.dart';
 
 import '../protocol.dart';
 
-final class AsyncSqliteController extends DatabaseController {
+base class AsyncSqliteController extends DatabaseController {
   @override
   Future<WorkerDatabase> openDatabase(
       WasmSqlite3 sqlite3, String path, String vfs) async {

test/basic_shared_test.dart

@@ -38,6 +38,8 @@ void main() {
               'INSERT INTO test_data(description) VALUES(?)', ['test']);
         }, throwsA((e) => e is LockError && e.message.contains('tx.execute')));
       });
+      // Uncomment this to break this test
+      // await db.close();
     });
 
     test('should allow PRAMGAs', () async {