refactor: Fix static analysis warnings about function prototypes

Newer version of clang enable the -Wstrict-prototypes flag by default.
This commit adds the needed prototype on functions where it was missing.

Author: gfieni

src/config.c

@@ -44,7 +44,7 @@
 #define DEFAULT_CGROUP_BASEPATH "/sys/fs/cgroup/perf_event"
 
 struct config *
-config_create()
+config_create(void)
 {
     struct config *config = malloc(sizeof(struct config));
 
@@ -337,7 +337,7 @@ config_setup_from_file(struct config *config, bson_t * doc)
 }
 
 static void
-print_usage()
+print_usage(void)
 {
     // TODO: write an usage text
 }

src/config.h

@@ -83,7 +83,7 @@ struct config
 /*
  * config_create allocate the required resources and setup the default config.
  */
-struct config *config_create();
+struct config *config_create(void);
 
 /*
  * parse_config_file extract the config file path from command line arguments.

src/hwinfo.c

@@ -37,7 +37,7 @@
 #include "util.h"
 
 static struct hwinfo_pkg *
-hwinfo_pkg_create()
+hwinfo_pkg_create(void)
 {
     struct hwinfo_pkg *pkg = malloc(sizeof(struct hwinfo_pkg));
 
@@ -222,7 +222,7 @@ hwinfo_detect(struct hwinfo *hwinfo)
 }
 
 struct hwinfo *
-hwinfo_create()
+hwinfo_create(void)
 {
     struct hwinfo *hw = malloc(sizeof(struct hwinfo));
 

src/hwinfo.h

@@ -59,7 +59,7 @@ struct hwinfo
 /*
  * hwinfo_create allocate the needed ressources.
  */
-struct hwinfo *hwinfo_create();
+struct hwinfo *hwinfo_create(void);
 
 /*
  * hwinfo_detect discover and store the machine hardware topology.

src/payload.c

@@ -36,7 +36,7 @@
 #include "payload.h"
 
 struct payload_cpu_data *
-payload_cpu_data_create()
+payload_cpu_data_create(void)
 {
     struct payload_cpu_data *data = malloc(sizeof(struct payload_cpu_data));
 
@@ -62,7 +62,7 @@ payload_cpu_data_destroy(struct payload_cpu_data **data_ptr)
 }
 
 struct payload_pkg_data *
-payload_pkg_data_create()
+payload_pkg_data_create(void)
 {
     struct payload_pkg_data *data = malloc(sizeof(struct payload_pkg_data));
 
@@ -87,7 +87,7 @@ payload_pkg_data_destroy(struct payload_pkg_data **data_ptr)
 }
 
 struct payload_group_data *
-payload_group_data_create()
+payload_group_data_create(void)
 {
     struct payload_group_data *data = malloc(sizeof(struct payload_group_data));
 

src/payload.h

@@ -81,7 +81,7 @@ void payload_destroy(struct payload *payload);
 /*
  * payload_group_data_create allocate the resources of an events group data container.
  */
-struct payload_group_data *payload_group_data_create();
+struct payload_group_data *payload_group_data_create(void);
 
 /*
  * payload_group_data_destroy free the allocated resources of the events group data container.
@@ -91,7 +91,7 @@ void payload_group_data_destroy(struct payload_group_data **data_ptr);
 /*
  * payload_pkg_data_create allocate the resources of a package data container.
  */
-struct payload_pkg_data *payload_pkg_data_create();
+struct payload_pkg_data *payload_pkg_data_create(void);
 
 /*
  * payload_pkg_data_destroy free the allocated resources of the package data container.
@@ -101,7 +101,7 @@ void payload_pkg_data_destroy(struct payload_pkg_data **data_ptr);
 /*
  * payload_cpu_data_create allocate the resources of a cpu data container.
  */
-struct payload_cpu_data *payload_cpu_data_create();
+struct payload_cpu_data *payload_cpu_data_create(void);
 
 /*
  * payload_cpu_data_destroy free the allocated resources of the cpu data container.

src/perf.c

@@ -85,7 +85,7 @@ perf_event_fd_destroy(int **fd_ptr)
 }
 
 static struct perf_group_cpu_context *
-perf_group_cpu_context_create()
+perf_group_cpu_context_create(void)
 {
     struct perf_group_cpu_context *ctx = malloc(sizeof(struct perf_group_cpu_context));
 
@@ -111,7 +111,7 @@ perf_group_cpu_context_destroy(struct perf_group_cpu_context **ctx)
 }
 
 static struct perf_group_pkg_context *
-perf_group_pkg_context_create()
+perf_group_pkg_context_create(void)
 {
     struct perf_group_pkg_context *ctx = malloc(sizeof(struct perf_group_pkg_context));
 
@@ -559,7 +559,7 @@ perf_monitoring_actor(zsock_t *pipe, void *args)
 }
 
 int
-perf_try_global_counting_event_open()
+perf_try_global_counting_event_open(void)
 {
     struct perf_event_attr pe = {0};
     int fd;

src/perf.h

@@ -123,7 +123,7 @@ void perf_monitoring_actor(zsock_t *pipe, void *args);
  * perf_try_event_open try to open a global counting event using the perf_event_open syscall.
  * This is used to check if the perf_event_open syscall is working and the current process is allowed to use it.
  */
-int perf_try_global_counting_event_open();
+int perf_try_global_counting_event_open(void);
 
 #endif /* PERF_H */
 

src/pmu.c

@@ -36,7 +36,7 @@
 #include "util.h"
 
 int
-pmu_initialize()
+pmu_initialize(void)
 {
     if (pfm_initialize() != PFM_SUCCESS) {
         return -1;
@@ -46,13 +46,13 @@ pmu_initialize()
 }
 
 void
-pmu_deinitialize()
+pmu_deinitialize(void)
 {
     pfm_terminate();
 }
 
 struct pmu_info *
-pmu_info_create()
+pmu_info_create(void)
 {
     struct pmu_info *pmu = malloc(sizeof(struct pmu_info));
     return pmu;
@@ -83,7 +83,7 @@ pmu_info_destroy(struct pmu_info **pmu)
 }
 
 struct pmu_topology *
-pmu_topology_create()
+pmu_topology_create(void)
 {
     struct pmu_topology *topology = malloc(sizeof(struct pmu_topology));
 

src/pmu.h

@@ -54,17 +54,17 @@ struct pmu_topology
 /*
  * pmu_initialize allocate the resources needed to use the PMUs.
  */
-int pmu_initialize();
+int pmu_initialize(void);
 
 /*
  * pmu_deinitialize free the allocated resources needed to use the PMUs.
  */
-void pmu_deinitialize();
+void pmu_deinitialize(void);
 
 /*
  * pmu_info_create allocate the resources needed for a pmu info container.
  */
-struct pmu_info *pmu_info_create();
+struct pmu_info *pmu_info_create(void);
 
 /*
  * pmu_info_dup duplicate the given pmu info.
@@ -79,7 +79,7 @@ void pmu_info_destroy(struct pmu_info **pmu);
 /*
  * pmu_topology_create allocate the resource needed for a pmu topology container.
  */
-struct pmu_topology *pmu_topology_create();
+struct pmu_topology *pmu_topology_create(void);
 
 /*
  * pmu_topology_destroy free the allocated resource of the pmu topology container.