feat: allow skipping node prechecks on upgrade - #138
Open
ludwighansson wants to merge 1 commit into
Open
Conversation
Allow the user to skip the node prechecks, removing the requirement for nodes to be 'running'. This is useful if one or more nodes are stuck in e.g. 'booting' after deploying or upgrading the cluster with a bad machine image, that never reaches a 'running' state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I've just migrated my previously talhelper-managed clusters onto topf, and I really enjoy it so far!
I came across a scenario the other day where a few nodes were deployed with a broken image, which caused them to get stuck in a "booting" stage, and unable to make them running again.
With the current upgrade implementation, all nodes must be running before topf attempts to upgrade any of them, which might end up in a catch 22 scenario where the user cannot not recover the nodes (no rollback available as the nodes were just deployed), so I decided to implement an option to skip the prechecks for treating this exact scenario. The docs has been updated to describe the flag, as well as pairing it with
--nodes-filterto target the problematic nodes only when using this flag.Happy to hear your thoughts on this!
Cheers!