Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnome Terminal does not open completely maximized #1332

Open
rdong8 opened this issue Jan 23, 2022 · 4 comments
Open

Gnome Terminal does not open completely maximized #1332

rdong8 opened this issue Jan 23, 2022 · 4 comments

Comments

@rdong8
Copy link

rdong8 commented Jan 23, 2022

(1) Issue/Bug Description:

Gnome Terminal does not open completely maximized. Specifically on the bottom and right sides, the window edges don't extend completely to the edge of the screen.

(2) Steps to reproduce (if you know):

Open Gnome Terminal when Pop Shell tiling is enabled on Ubuntu 21.10 (does not occur on Pop!_OS). When Smart Gaps is disabled, it's only really the bottom edge that is out of place. When Smart Gaps is enabled, both the right and bottom edges of the window do not meet the screen edge. Occurs even when gaps are set to 0.

(3) Expected behavior:

Gnome Terminal is completely maximized like with other programs

(4) Distribution (run cat /etc/os-release):

PRETTY_NAME="Ubuntu 21.10"
NAME="Ubuntu"
VERSION_ID="21.10"
VERSION="21.10 (Impish Indri)"
VERSION_CODENAME=impish
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=impish

(5) Gnome Shell version:

40.5

(6) Pop Shell version (run apt policy pop-shell or provide the latest commit if building locally):

21745c4

(7) Where was Pop Shell installed from:

This repository

(8) Monitor Setup (2 x 1080p, 4K, Primary(Horizontal), Secondary(Vertical), etc):

1x1080p

(9) Other Installed/Enabled Extensions:

Occurs with all other extensions disabled

(10) Other Notes:

Smart gaps enabled:
image
Smart gaps disabled:
image

@pesader
Copy link

pesader commented Jan 23, 2022

GNOME Terminal's resizing is awkward in that it is "discrete", not "continuous".
It's window must be the size of an integer number of lines and an integer number of columns. The space you have down the bottom of the screen is likely not enough to fit an additional line, so GNOME Terminal just doesn't resize to it.

@rdong8
Copy link
Author

rdong8 commented Jan 23, 2022

Any idea what Pop!_OS does to get around this? I have two laptops with identical screens, but the one with Pop!_OS sizes Gnome Terminal just fine but the one with Ubuntu + Pop Shell can't

@pesader
Copy link

pesader commented Jan 23, 2022

As far as I know, this GNOME Terminal limitation cannot be circumvented. It was even mentioned by other extensions that provide similar functionality.
You may have different scaling settings or font sizes on your laptops.

@carlwgeorge
Copy link
Contributor

Any idea what Pop!_OS does to get around this?

I think it's this patch.

https://github.com/pop-os/gnome-terminal/blob/master_impish/debian/patches/pop-shell.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants