Skip to content

Commit 0a63b0f

Browse files
authored
Merge pull request #344 from polkadot-ui/nik-retry-connect-from-scratch
Fix the type of account
2 parents 2e45ce8 + 023e26b commit 0a63b0f

File tree

7 files changed

+12
-29
lines changed

7 files changed

+12
-29
lines changed

packages/ui-react/lib/components/Connect/Connect.tsx

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
import { Dispatch, SetStateAction, useState } from "react"
22
import { ConnectAccounts } from "./ConnectAccounts"
33
import { ConnectExtensions } from "./ConnectExtensions"
4-
import { SelectedAccountType, ConnectConfiguration } from "./types"
4+
import { ConnectConfiguration } from "./types"
55
import {
66
InjectedExtension,
77
InjectedPolkadotAccount,
88
} from "polkadot-api/pjs-signer"
99
import { ConnectAccountsProvider } from "."
1010

1111
export const Connect: React.FC<{
12-
selected?: SelectedAccountType
13-
setSelected: Dispatch<SetStateAction<SelectedAccountType>>
12+
selected?: InjectedPolkadotAccount
13+
setSelected: Dispatch<SetStateAction<InjectedPolkadotAccount>>
1414
config?: ConnectConfiguration
1515
type?: "onepage" | "extensions" | "split"
1616
onSelectExtensions?: (ext: Map<string, InjectedExtension>) => void
@@ -45,14 +45,14 @@ export const Connect: React.FC<{
4545
justifyContent: "space-between",
4646
}}
4747
>
48-
<div style={{ width: "45%", padding: "1rem" }}>
48+
<div style={{ width: "46%", padding: "1rem" }}>
4949
<ConnectExtensions
5050
setSelected={setSelected}
5151
config={config}
5252
onSelectExtensions={(ext) => setSplitExtension(ext)}
5353
/>
5454
</div>
55-
<div style={{ width: "45%", padding: "1rem" }}>
55+
<div style={{ width: "46%", padding: "1rem" }}>
5656
{splitExtensions && (
5757
<ConnectAccountsProvider value={[...splitExtensions.values()]}>
5858
<ConnectAccounts

packages/ui-react/lib/components/Connect/ConnectExtensions.tsx

+3-7
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,7 @@ import { useEffect, useState, useSyncExternalStore } from "react"
44
import { extensionCtx } from "./extensionCtx"
55
import { getExtensionIcon } from "@polkadot-ui/assets/extensions"
66
import { useAvailableExtensions, useExtensionStorage } from "./hooks"
7-
import type {
8-
ConnectConfiguration,
9-
NameUrlType,
10-
SelectedAccountType,
11-
} from "./types"
7+
import type { ConnectConfiguration, NameUrlType } from "./types"
128
import { Any } from "../../utils"
139
import { getExtensionsStore, localStorageKeyExtensions } from "./utils"
1410
import {
@@ -47,7 +43,7 @@ extensionsStore.subscribe(Function.prototype as Any)
4743

4844
export const ConnectExtensions: FC<
4945
PropsWithChildren<{
50-
setSelected: Dispatch<SetStateAction<SelectedAccountType>>
46+
setSelected: Dispatch<SetStateAction<InjectedPolkadotAccount>>
5147
config?: ConnectConfiguration
5248
onSelectExtensions?: (ext: Map<string, InjectedExtension>) => void
5349
getConnectedAccounts?: (acc: InjectedPolkadotAccount[]) => void
@@ -151,7 +147,7 @@ const ExtButton: React.FC<
151147
PropsWithChildren & {
152148
name: string
153149
config: ConnectConfiguration
154-
setSelected: Dispatch<SetStateAction<SelectedAccountType>>
150+
setSelected: Dispatch<SetStateAction<InjectedPolkadotAccount>>
155151
setExtensionLocalStorage: Any
156152
extensions: Any
157153
url?: string

packages/ui-react/lib/components/Connect/index.ts

-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ export type {
1414
ConnectConfiguration,
1515
ConfigType,
1616
CommonConfigType,
17-
SelectedAccountType,
1817
} from "./types"
1918

2019
export { localStorageKeyAccount, localStorageKeyExtensions } from "./utils"

packages/ui-react/lib/components/Connect/types.tsx

-10
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,4 @@
11
import { Any } from "../../utils"
2-
import { PolkadotSigner } from "polkadot-api"
3-
import { KeypairType } from "polkadot-api/pjs-signer"
4-
5-
export type SelectedAccountType = {
6-
address: string
7-
name?: string
8-
type?: KeypairType
9-
extension: string
10-
polkadotSigner: PolkadotSigner
11-
} | null
122

133
export type ConnectConfiguration = ConfigType & CommonConfigType
144

packages/ui-react/lib/components/Connect/utils.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import {
22
InjectedExtension,
3+
InjectedPolkadotAccount,
34
connectInjectedExtension,
45
} from "polkadot-api/pjs-signer"
56
import { Dispatch, SetStateAction } from "react"
6-
import { SelectedAccountType } from "./types"
77
import { Any } from "../../utils"
88

99
const { location } = window
@@ -72,7 +72,7 @@ export const getExtensionsStore = () => {
7272

7373
const onToggleExtension = (
7474
name: string,
75-
setSelected: Dispatch<SetStateAction<SelectedAccountType>>
75+
setSelected: Dispatch<SetStateAction<InjectedPolkadotAccount>>
7676
) => {
7777
if (isRunning) return
7878

packages/ui-react/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@polkadot-ui/react",
33
"license": "MIT",
4-
"version": "0.0.1-alpha.29",
4+
"version": "0.0.1-alpha.30",
55
"author": "Nikolaos Kontakis<[email protected]>",
66
"type": "module",
77
"description": "Functional React components for Polkadot dApps.",

sandbox/src/pages/Components.tsx

+1-3
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import {
44
Chart,
55
AccountCard,
66
IconProps,
7-
SelectedAccountType,
87
ConnectConfiguration,
98
Connect,
109
ConnectExtensions,
@@ -28,8 +27,7 @@ export const Components = () => {
2827
const updateValue2 = () => setVal2(Number((val2 + 17491.390013).toFixed(4)))
2928

3029
// Connect recipe
31-
const [selectedAccount, setSelectedAccount] =
32-
useState<SelectedAccountType>(null)
30+
const [selectedAccount, setSelectedAccount] = useState(null)
3331

3432
const address = "1f1yYj2bCFhJCTVdeWLDueUsrZynLAaj6jeMy18fjZ7Cr73"
3533
const address2 = "13QqEYyFfeWmBVr3QvfhwpYrXoUFDgs7ViYhxv2fvLHe6mtT"

0 commit comments

Comments
 (0)