Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: determinism test of the algorithm #93

Closed
poja opened this issue Oct 24, 2022 · 6 comments
Closed

Tests: determinism test of the algorithm #93

poja opened this issue Oct 24, 2022 · 6 comments

Comments

@poja
Copy link
Owner

poja commented Oct 24, 2022

Make sure the algorithm is deterministic when temp=noise=0

@barakugav
Copy link
Collaborator

We can add such test now, but i think we will have to modify it in the future.
Currently we use multiple threads, each running a different search on a different game. In the future, we might want to use multiple threads in the same player, on the same tree search. This may result in a different searches even without random noise

@poja
Copy link
Owner Author

poja commented Oct 24, 2022

Oh nice catch
But anyway this test can be run with a single thread, I think that proves its point

@barakugav
Copy link
Collaborator

k cool, good idea

@barakugav
Copy link
Collaborator

So i guss such test will fail, due to the FP errors @poja

@poja
Copy link
Owner Author

poja commented Oct 31, 2022

Annoying, but seems true.
Maybe this is the "noise" they were talking about in the paper? 😅
#87

@barakugav
Copy link
Collaborator

Maybe, they also have noise from multithreadind search

@barakugav barakugav closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants