Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepencies between tests results depending to Intel and ARM64 architectures (issue with Apple Silicon SoC on GitHub Action runner) #932

Open
pylapp opened this issue Dec 11, 2024 · 1 comment

Comments

@pylapp
Copy link

pylapp commented Dec 11, 2024

Context

We use the swift-snapshot-testing library to make UI tests on our components.

All the tests pass locally in our MacBook Pro computers, based on Intel architecture (e.g. Intel Core i9 and MacBook Pro 2019 16"). Our CI/CD internal chain, using also such computers with the same architecture, keeps all the tests green.

However, using the GitHub Action runners, some tests fail. Always the same. We ensure the macOS version was the same between each computer (i.e. macOS 15), and also the Xcode version (16.0), the simulator in use (iPhone 16 Pro), and its OS verison (iOS 18.0). The code base is the same, the tests base is the same, the only difference remains in the architecture of the computer.

Indeed, GitHub Actions exposes a macOS 15 runner (named macos-15) based on ARM architecture according to their documentation with M1 SoC and only on this environment some tests fail. It seems GitHub exposes, for free plans, only arm64-absed environments and not Intel-based anymore.
The runners based on Intel architecture are not available for us (i.e. "large runners"). It seems they did not plan to expose Intel-based macOS 15 now.

In few words, we are pretty sure some UI tests do not work anymore if the architecture behind is arm64, i.e. Apple SIlicon, and not Intel 😱

Expected behavior

Having our tests passing for whatever the architecture is, i.e. for both Intel-based and arm64-based architectures.

Environment

  • Xcode 16
  • Swift 6
  • iPhone 16 Pro simulator with iOS 18.0
  • swift-snapshot-testing version 1.17.6

Additional context

It seems some users got the same troubles:

Today we enable a condition accepting the tests fail in GitHub Action but that's not the expect workaround 😅

@pylapp
Copy link
Author

pylapp commented Dec 11, 2024

@stephencelis @mbrandonw I hope these details help :)
BTW your library is awesome 🤩

@pylapp pylapp changed the title Discrepencies between Intel and ARM64 architectures making tests fail if Apple Silicon SoC (GitHub Action runner) Discrepencies between tests results depending to Intel and ARM64 architectures (issue with Apple Silicon SoC on GitHub Action runner) Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant