Feat/download foreign layers#2875
Open
IanEff wants to merge 2 commits into
Open
Conversation
Contributor
|
@IanEff this needs a rebase also. |
Signed-off-by: Ian Furst <ian.furst@gmail.com>
Add TestCopyDownloadForeignLayers asserting the user-visible effect of the flag: the foreign blob is present in blobs/sha256/ when set, absent when not. Manifest contents are out of scope; the upstream library downloads the blob but does not rewrite the nondistributable media type or strip the urls field (a separate gap in containers/container-libs). Closes podman-container-tools#545 Signed-off-by: Ian Furst <ian.furst@gmail.com>
IanEff
force-pushed
the
feat/download-foreign-layers
branch
from
643cea2 to
275c80b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
--download-foreign-layerstoskopeo copyandskopeo sync.When set, the flag instructs containers/image to fetch the contents of
nondistributable ("foreign") layers — e.g. Windows base layers — instead
of preserving only a URL reference to their original location. This is
useful for air-gapped copies of images whose upstream source may later
become unreachable.
Note that the underlying
copy.Options.DownloadForeignLayersfetches the blob butdoes not rewrite the manifest media type or strip the
urlsfield; thisis a known gap in containers/container-libs (originally containers/image#1998).
The integration test and man pages describe what users will actually observe
rather than what the upstream doc-comment promises.
I'll work to close that bug, but this should suffice to close this issue.
Closes #545