feat(manifest-push): add --timestamp parameter#6899
Open
aeijdenberg wants to merge 1 commit into
Open
Conversation
nalind
requested changes
Jun 8, 2026
nalind
left a comment
nalind
left a comment
Contributor
There was a problem hiding this comment.
Generally looks good, but a description of the new flag should be added to docs/buildah-manifest-push.1.md.
nalind
reviewed
Jun 8, 2026
aeijdenberg
force-pushed
the
fixmanifesttimestamp
branch
from
6243700 to
55a5d22
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
1 similar comment
|
Ephemeral COPR build failed. @containers/packit-build please check. |
Contributor
Author
Done |
This is similar to options already added to build etc, and will set any timestamps in destination contents (such as tar file header entries) to this value. Helps with reproducible builds. Signed-off-by: Adam Eijdenberg <adam@continusec.com>
aeijdenberg
force-pushed
the
fixmanifesttimestamp
branch
from
55a5d22 to
f26f64d
Compare
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is similar to options already added to build etc, and will set any timestamps in destination contents (such as tar file header entries) to this value. Helps with reproducible builds.
What type of PR is this?
What this PR does / why we need it:
Adds
--timestamp 0flag tomanifest pushwhich sets the timestamp on any tar entries to the specified time.How to verify it
Added new bats test.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Have opened podman-container-tools/container-libs#899 for the change to the library.
There's a few extra lines in this PR to accommodate the user not setting the timestamp (ie current behaviour). If it were up to me, I'd probably just default it to 0 and not special case, but to keep the change minimal I tried to match existing patterns to make the flag optional.
Does this PR introduce a user-facing change?