Skip to content

fix: Fix ref as prop causing circular reference in useMemo in React 19 #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Fix ref as prop causing circular reference in useMemo in React 19 #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/util.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ const components = new WeakMap<EffectConstructor, React.ExoticComponent<any> | s
export const wrapEffect = <T extends EffectConstructor>(effect: T, defaults?: EffectProps<T>) =>
/* @__PURE__ */ function Effect({ blendFunction = defaults?.blendFunction, opacity = defaults?.opacity, ...props }) {
let Component = components.get(effect)
const { ref, ...params } = props
if (!Component) {
const key = `@react-three/postprocessing/${effect.name}-${i++}`
extend({ [key]: effect })
Expand All @@ -29,9 +30,9 @@ export const wrapEffect = <T extends EffectConstructor>(effect: T, defaults?: Ef

const camera = useThree((state) => state.camera)
const args = React.useMemo(
() => [...(defaults?.args ?? []), ...(props.args ?? [{ ...defaults, ...props }])],
() => [...(defaults?.args ?? []), ...(params.args ?? [{ ...defaults, ...params }])],
// eslint-disable-next-line react-hooks/exhaustive-deps
[JSON.stringify(props)]
[JSON.stringify(params)]
)

return (
Expand Down