Replace runWithTransactions to flushCallbacks finalizer for Improved Flow Control and Compatibility #2946
+65
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/DQ67EHCB5 |
See documentations for usage instructions.
dmaskasky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current implementation with
runWithTransactionsuses a single synchronous callback (fn) invocation followed by conditionally running store hooks. For some flows, this code reduces to simply callingfn. The states in which hooks should be called are well defined so refactoring to synchronously calling a finalizer (flushCallbacks) is introduced in this PR.A side-effect of this PR is it resolves several incompatibilities with jotai-effect.
Details
flushCallbacksis called at the end of 7 flows:Check List
pnpm run fix:formatfor formatting code and docs