Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main.yml might fail due to changes in GitHub runner configuration. #6134

Open
grom72 opened this issue Jan 20, 2025 · 0 comments · May be fixed by #6135
Open

main.yml might fail due to changes in GitHub runner configuration. #6134

grom72 opened this issue Jan 20, 2025 · 0 comments · May be fixed by #6135
Labels
Type: Bug A previously unknown bug in PMDK

Comments

@grom72
Copy link
Contributor

grom72 commented Jan 20, 2025

ISSUE: main.yml might fail due to changes in GitHub runner configuration.

Please provide a reproduction of the bug:

main.yml is used to PR validation.
It might fail incidentally due to changes in GitHub runner configuration - for example due to change of clang version:

FAIL: requires clang-format version==14.0

or new default compiler settings:

libpmem.c:131:34: error: cast from 'pmem_log_function *' (aka 'void (*)(enum pmem_log_level, const char *, unsigned int, const char *, const char *)') to 'core_log_function *' (aka 'void (*)(enum core_log_level, const char *, unsigned int, const char *, const char *)') converts to incompatible function type [-Werror,-Wcast-function-type-strict]
  131 |         int ret = core_log_set_function((core_log_function *)log_function);
      |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

https://github.com/pmem/pmdk/actions/runs/12829605544

Such changes should be detected sooner than on PR validation.
That means main.yml workflow shall be run regularly.

Additional information about Priority and Help Requested:

Are you willing to submit a pull request with a proposed change? (Yes, No) Yes

Requested priority: (Showstopper, High, Medium, Low) Medium

@grom72 grom72 added the Type: Bug A previously unknown bug in PMDK label Jan 20, 2025
grom72 added a commit to grom72/pmdk that referenced this issue Jan 20, 2025
Regular run main.yml workflow to avoid incidental PR
validation failures as described in
pmem#6134

Signed-off-by: Tomasz Gromadzki <[email protected]>
grom72 added a commit to grom72/pmdk that referenced this issue Jan 20, 2025
Regular run main.yml workflow to avoid incidental PR
validation failures as described in
pmem#6134

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72 grom72 linked a pull request Jan 20, 2025 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug A previously unknown bug in PMDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant