feat(ime-389): align connection-manager-ui with mojaloop standards by improving test coverage #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijayg10
reviewed
May 12, 2025
| @@ -0,0 +1,109 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Contributor
There was a problem hiding this comment.
What are these files? may be you need to remove
| @@ -0,0 +1 @@ | |||
| {"processes":{"0e789316-83e2-4469-a605-ea4fdd1603cc":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"1412f4f9-9d65-4ce2-87a2-9b88e20deb3a":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0":{"parent":"6d5de229-1ad4-4583-9e39-ba0458720bb9","children":["0e789316-83e2-4469-a605-ea4fdd1603cc","1412f4f9-9d65-4ce2-87a2-9b88e20deb3a","1cfc9d1a-33bb-4f5a-9513-adf863476f5e","2379e91b-48d7-4c0e-9df4-001b665f13b8","2a4a414b-374f-4b56-939b-d7ddd4789429","2d46ae50-7223-4b8b-970d-8508dc8e1a6a","300acf8b-e281-4642-be10-08ca297a2b13","409ffde9-5e3c-4f0e-8bf7-d03b6c2f7bf2","46f5daf6-225b-4b23-8071-4813eee05beb","4ff61bd2-2e6c-41ed-9239-78e7e02e270e","501daf24-ab18-4298-aa6f-6b128c99c98e","53a1c048-e5fb-41b5-8322-76ca51bd8e7d","54290fe6-067a-4990-b6d5-c697864acbf4","59f3ee13-0a26-40f9-9898-fc4094d2965b","5b8e90d3-d157-44d5-aea4-17e8891a955b","5ba4c880-6dd1-4056-a431-d49e2c18b740","5bddd2d9-c468-43af-9ab8-0c2585fbc9fa","7f8c7c98-01cf-4f2a-a9e0-58696d41fc68","8733b954-3baa-4588-9523-dfcd02dc267c","91701a0f-cef0-43e9-add1-98ebb98729e7","9de7b2ba-1f6c-426f-b78c-add3d4c6d6c6","a85e5015-f573-45c9-ba5a-108b69cefa52","acdb87b0-ac7d-48ab-a428-a54fe8e97320","b94e18bc-e4e6-42e6-aeab-ae9d0cfb1266","bd63d775-51fa-4270-a413-e9654efe47ec","cd5a9d86-a559-42cb-88ec-b7c2ddd6a4be","d79a2f5d-643c-4ae2-b189-bbf57cea718a","dc0384e5-a547-4ac1-8570-8de7d12623ae","e69c4e70-b55b-4fc8-9560-06d7a5607756","eebefa7c-781e-430d-927f-01a42c74acab","f15300da-d17c-4746-9880-34218e8ef1aa","fc0dbf4c-0aa3-4e91-9a37-4460e7fcb733","fe92f3be-28d2-48b6-b791-11fbff990b6b"]},"1cfc9d1a-33bb-4f5a-9513-adf863476f5e":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"2379e91b-48d7-4c0e-9df4-001b665f13b8":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"2a4a414b-374f-4b56-939b-d7ddd4789429":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"2c295b19-e3ad-4220-be83-5aa2d6c131b8":{"parent":null,"children":["6d5de229-1ad4-4583-9e39-ba0458720bb9"]},"2d46ae50-7223-4b8b-970d-8508dc8e1a6a":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"300acf8b-e281-4642-be10-08ca297a2b13":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"409ffde9-5e3c-4f0e-8bf7-d03b6c2f7bf2":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"46f5daf6-225b-4b23-8071-4813eee05beb":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"4ff61bd2-2e6c-41ed-9239-78e7e02e270e":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"501daf24-ab18-4298-aa6f-6b128c99c98e":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"53a1c048-e5fb-41b5-8322-76ca51bd8e7d":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"54290fe6-067a-4990-b6d5-c697864acbf4":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"59f3ee13-0a26-40f9-9898-fc4094d2965b":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"5b8e90d3-d157-44d5-aea4-17e8891a955b":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"5ba4c880-6dd1-4056-a431-d49e2c18b740":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"5bddd2d9-c468-43af-9ab8-0c2585fbc9fa":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"6d5de229-1ad4-4583-9e39-ba0458720bb9":{"parent":"2c295b19-e3ad-4220-be83-5aa2d6c131b8","children":["1782fdb5-ae0a-4a3c-b59b-2f59806e74d0"]},"7f8c7c98-01cf-4f2a-a9e0-58696d41fc68":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"8733b954-3baa-4588-9523-dfcd02dc267c":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"91701a0f-cef0-43e9-add1-98ebb98729e7":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"9de7b2ba-1f6c-426f-b78c-add3d4c6d6c6":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"a85e5015-f573-45c9-ba5a-108b69cefa52":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"acdb87b0-ac7d-48ab-a428-a54fe8e97320":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"b94e18bc-e4e6-42e6-aeab-ae9d0cfb1266":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"bd63d775-51fa-4270-a413-e9654efe47ec":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"cd5a9d86-a559-42cb-88ec-b7c2ddd6a4be":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"d79a2f5d-643c-4ae2-b189-bbf57cea718a":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"dc0384e5-a547-4ac1-8570-8de7d12623ae":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"e69c4e70-b55b-4fc8-9560-06d7a5607756":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"eebefa7c-781e-430d-927f-01a42c74acab":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"f15300da-d17c-4746-9880-34218e8ef1aa":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"fc0dbf4c-0aa3-4e91-9a37-4460e7fcb733":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]},"fe92f3be-28d2-48b6-b791-11fbff990b6b":{"parent":"1782fdb5-ae0a-4a3c-b59b-2f59806e74d0","children":[]}},"files":{"/home/mataa23/connection-manager-ui/config-overrides.js":["1782fdb5-ae0a-4a3c-b59b-2f59806e74d0"]},"externalIds":{}} No newline at end of file | |||
Contributor
There was a problem hiding this comment.
May be add to gitignore also
| ENV PATH=$NVM_DIR/versions/node/v$NODE_VERSION/bin:$PATH | ||
|
|
||
| # First part, build the app | ||
| WORKDIR /app |
Contributor
There was a problem hiding this comment.
I think mojaloop standard is /opt/app. And this dockerfile is deviating from the other repos. Please check
| @@ -0,0 +1,2381 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
I think we don't need results in the commits. Also add to gitignore
| @@ -1 +1 @@ | |||
| CONNECTION_MANAGER_ENDPOINT=http://localhost:3000 | |||
| CONNECTION_MANAGER_ENDPOINT=http://localhost:8081 | |||
Contributor
There was a problem hiding this comment.
Why there is change in port?
Comment on lines
-30
to
+31
| "test": "testcafe ${BROWSER_TCAFE:-chrome}", | ||
| "test:headless": "testcafe ${BROWSER_TCAFE:-chrome:headless}" | ||
| "test": "npx testcafe ${BROWSER_TCAFE:-firefox}", | ||
| "test:headless": "npx testcafe ${BROWSER_TCAFE:-firefox:headless}" |
Contributor
There was a problem hiding this comment.
Why its changed? Did we test this in Linux, MacOS and Windows?
| @@ -0,0 +1,151 @@ | |||
| The "reporter" option from the configuration file will be ignored. | |||
Contributor
There was a problem hiding this comment.
We don't need reports in commits. Add to gitignore
| @@ -0,0 +1,13669 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
Delete this file and add it to gitignore
| @@ -1,43 +1,63 @@ | |||
| { | |||
| "name": "connection-manager-ui", | |||
| "version": "1.8.4", | |||
Contributor
There was a problem hiding this comment.
Please remove kustomize binary from this commit.
| }); | ||
| }); | ||
|
|
||
| describe('Test the dfsp egress endpoints thunk actions', () => { |
Contributor
There was a problem hiding this comment.
It seems lot of tests are removed. How did we achieve code coverage after removing all these tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.