feat(IPROD-189-3): used Keycloak to perform /login action to do OAuth 2.0 authorization code flow #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….0 authorization code flow
Contributor
|
lgtm so far, fix checks and I can approve. was there some reason we couldn't of used some library for this? |
kleyow
previously approved these changes
Sep 26, 2023
kleyow
changed the title
…after login from root route)
mdebarros
reviewed
Oct 9, 2023
mdebarros
reviewed
Oct 11, 2023
Member
mdebarros
left a comment
mdebarros
left a comment
There was a problem hiding this comment.
Just some suggested wording changes.
Please let me know if you agree with the changes.
Co-authored-by: Miguel de Barros <[email protected]>
mdebarros
reviewed
Oct 11, 2023
Co-authored-by: Miguel de Barros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use Keycloak to authenticate users to follow OAuth 2.0 authorization code flow for MCM layer (hub operator)
Env variables:
AUTH_ENABLEDis disabled by default (previous auth flow)UI_OIDC_LOGIN_REDIRECT_URL- URL to redirect user to provide creds and grand permissions (Keycloack)OIDC_TOKEN_PROVIDER_URL- URL to exchange authorization code for access token (providing also client ID and secret)OIDC_CLIENT_ID- MCM portal OIDC client id (in Keycloak)OIDC_CLIENT_SECRET- MCM portal OIDC client secret (in Keycloak)