Feat(Build) add REctor (#1029)

* Feat(Build) add REctor

* fix

* Update ajax/container.php

Co-authored-by: Romain B. <[email protected]>

* Update ajax/reorder.php

Co-authored-by: Romain B. <[email protected]>

* Update inc/labeltranslation.class.php

Co-authored-by: Romain B. <[email protected]>

* Update inc/profile.class.php

Co-authored-by: Romain B. <[email protected]>

* Update inc/toolbox.class.php

Co-authored-by: Romain B. <[email protected]>

* fix

* Apply suggestion from @Rom1-B

---------

Co-authored-by: Romain B. <[email protected]>

Author: stonebuzz

.twig_cs.dist.php

@@ -2,14 +2,16 @@
 
 declare(strict_types=1);
 
-use FriendsOfTwig\Twigcs;
+use FriendsOfTwig\Twigcs\Finder\TemplateFinder;
+use FriendsOfTwig\Twigcs\Config\Config;
+use Glpi\Tools\GlpiTwigRuleset;
 
-$finder = Twigcs\Finder\TemplateFinder::create()
+$finder = TemplateFinder::create()
     ->in(__DIR__ . '/templates')
     ->name('*.html.twig')
     ->ignoreVCSIgnored(true);
 
-return Twigcs\Config\Config::create()
+return Config::create()
     ->setFinder($finder)
-    ->setRuleSet(\Glpi\Tools\GlpiTwigRuleset::class)
+    ->setRuleSet(GlpiTwigRuleset::class)
 ;

ajax/container.php

@@ -28,15 +28,16 @@
  * -------------------------------------------------------------------------
  */
 
-include('../../../inc/includes.php');
-Session::checkLoginUser();
+use Glpi\Exception\Http\AccessDeniedHttpException;
+use Glpi\Exception\Http\NotFoundHttpException;
 
+Session::checkLoginUser();
 
 if (isset($_GET['action']) && $_GET['action'] === 'get_fields_html') {
 
     $right = PluginFieldsProfile::getRightOnContainer($_SESSION['glpiactiveprofile']['id'], $_GET['id']);
     if ($right < READ) {
-        throw new \Glpi\Exception\Http\AccessDeniedHttpException();
+        throw new AccessDeniedHttpException();
     }
 
     $containers_id = $_GET['id'];
@@ -49,7 +50,7 @@
     $dbu = new DbUtils();
     $item = $dbu->getItemForItemtype($itemtype);
     if ($items_id > 0 && !$item->getFromDB($items_id)) {
-        throw new \Glpi\Exception\Http\NotFoundHttpException();
+        throw new NotFoundHttpException();
     }
     $item->input = $input;
 
@@ -65,5 +66,5 @@
         echo '';
     }
 } else {
-    throw new \Glpi\Exception\Http\NotFoundHttpException();
+    throw new NotFoundHttpException();
 }

ajax/container_display_condition.php

@@ -27,8 +27,6 @@
  * @link      https://github.com/pluginsGLPI/fields
  * -------------------------------------------------------------------------
  */
-
-include('../../../inc/includes.php');
 Session::checkLoginUser();
 
 if (isset($_GET['action'])) {
@@ -55,5 +53,5 @@
         }
     }
 } else {
-    throw new \RuntimeException('Invalid request', 400);
+    throw new RuntimeException('Invalid request', 400);
 }

ajax/container_itemtypes_dropdown.php

@@ -28,7 +28,6 @@
  * -------------------------------------------------------------------------
  */
 
-include('../../../inc/includes.php');
 Session::checkLoginUser();
 
 PluginFieldsContainer::showFormItemtype($_REQUEST);

ajax/container_subtype_dropdown.php

@@ -28,7 +28,6 @@
  * -------------------------------------------------------------------------
  */
 
-include('../../../inc/includes.php');
 Session::checkLoginUser();
 
 PluginFieldsContainer::showFormSubtype($_REQUEST, true);

ajax/field_specific_fields.php

@@ -31,7 +31,6 @@
  * -------------------------------------------------------------------------
  */
 
-include('../../../inc/includes.php');
 header('Content-Type: text/html; charset=UTF-8');
 Html::header_nocache();
 Session::checkLoginUser();
@@ -66,11 +65,9 @@
         echo implode(
             ', ',
             array_map(
-                function ($itemtype) {
-                    return is_a($itemtype, CommonDBTM::class, true)
-                    ? $itemtype::getTypeName(Session::getPluralNumber())
-                    : $itemtype;
-                },
+                fn($itemtype) => is_a($itemtype, CommonDBTM::class, true)
+                ? $itemtype::getTypeName(Session::getPluralNumber())
+                : $itemtype,
                 $allowed_itemtypes,
             ),
         );

ajax/reorder.php

@@ -28,7 +28,8 @@
  * -------------------------------------------------------------------------
  */
 
-include('../../../inc/includes.php');
+use Glpi\DBAL\QueryExpression;
+
 Session::checkLoginUser();
 
 if (
@@ -37,7 +38,7 @@
     || !array_key_exists('new_order', $_POST)
 ) {
     // Missing input
-    throw new \RuntimeException('Missing input', 400);
+    throw new RuntimeException('Missing input', 400);
 }
 
 $table        = PluginFieldsField::getTable();
@@ -62,7 +63,7 @@
 
 if (0 === $field_iterator->count()) {
     // Unknown field
-    throw new \RuntimeException('Unknown field', 404);
+    throw new RuntimeException('Unknown field', 404);
 }
 
 $field_id = $field_iterator->current()['id'];
@@ -72,7 +73,7 @@
     $DB->update(
         $table,
         [
-            'ranking' => new \Glpi\DBAL\QueryExpression($DB->quoteName('ranking') . ' - 1'),
+            'ranking' => new QueryExpression($DB->quoteName('ranking') . ' - 1'),
         ],
         [
             'plugin_fields_containers_id' => $container_id,
@@ -84,7 +85,7 @@
     $DB->update(
         $table,
         [
-            'ranking' => new \Glpi\DBAL\QueryExpression($DB->quoteName('ranking') . ' + 1'),
+            'ranking' => new QueryExpression($DB->quoteName('ranking') . ' + 1'),
         ],
         [
             'plugin_fields_containers_id' => $container_id,

ajax/status_override.php

@@ -28,7 +28,6 @@
  * -------------------------------------------------------------------------
  */
 
-include('../../../inc/includes.php');
 Session::checkLoginUser();
 
 if (isset($_GET['action'])) {
@@ -43,5 +42,5 @@
         $status_override->showForm($_GET['id'], $_GET);
     }
 } else {
-    throw new \RuntimeException('Invalid request', 400);
+    throw new RuntimeException('Invalid request', 400);
 }

ajax/viewtranslations.php

@@ -32,22 +32,17 @@
 * @brief
 */
 
-include('../../../inc/includes.php');
 header('Content-Type: text/html; charset=UTF-8');
 Html::header_nocache();
 
 Session::checkLoginUser();
 
 if (!isset($_POST['itemtype']) || !isset($_POST['items_id']) || !isset($_POST['id'])) {
-    throw new \RuntimeException('Missing required parameters', 400);
+    throw new RuntimeException('Missing required parameters', 400);
 }
 
 $translation = new PluginFieldsLabelTranslation();
-if ($_POST['id'] == -1) {
-    $canedit = $translation->can(-1, CREATE, $_POST);
-} else {
-    $canedit = $translation->can($_POST['id'], UPDATE);
-}
+$canedit = $_POST['id'] == -1 ? $translation->can(-1, CREATE, $_POST) : $translation->can($_POST['id'], UPDATE);
 if ($canedit) {
     $translation->showFormForItem($_POST['itemtype'], $_POST['items_id'], $_POST['id']);
 } else {

front/container.php

@@ -28,7 +28,6 @@
  * -------------------------------------------------------------------------
  */
 
-include('../../../inc/includes.php');
 Session::checkLoginUser();
 
 Html::header(