Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading spinner stays on error #158

Open
xeruf opened this issue Oct 4, 2022 · 2 comments
Open

Loading spinner stays on error #158

xeruf opened this issue Oct 4, 2022 · 2 comments

Comments

@xeruf
Copy link
Contributor

xeruf commented Oct 4, 2022

It keeps on retrying, despite being rejected with "Too many requests"

image

@plepe
Copy link
Owner

plepe commented Oct 4, 2022

Yes that's right. It will retry loading up to three times (which is currently hard-coded). Between retry requests, there will be a pause of increasing time.

The relevant code is in module overpass-frontend. You can configure the options with the parameter 'overpassOptions' in OpenStreetBrowser's conf.php.

Here are the relevant options in overpass-frontend: https://github.com/plepe/overpass-frontend/blob/master/src/OverpassFrontend.js#L81

What should be added is a notification to the user, that the request has been blocked and will be retried. Any ideas how this could be displayed? Maybe some status indicator somewhere?

@xeruf
Copy link
Contributor Author

xeruf commented Oct 4, 2022

maybe replace the spinner by red text with the error code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants