Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code fails to follow Scalas own reccomended Style guide. #93

Closed
jeremyjjbrown opened this issue Mar 26, 2020 · 1 comment
Closed

Code fails to follow Scalas own reccomended Style guide. #93

jeremyjjbrown opened this issue Mar 26, 2020 · 1 comment
Labels
triage

Comments

@jeremyjjbrown
Copy link

Scala style is documented plainly.

https://docs.scala-lang.org/style/declarations.html
https://docs.scala-lang.org/style/indentation.html#line-wrapping

Yet this examples project fails to follow it for some reason.

class RequestHandler @Inject()(webCommands: WebCommands,
                               optDevContext: OptionalDevContext,
                               router: Router,
                               errorHandler: HttpErrorHandler,
                               configuration: HttpConfiguration,
                               filters: HttpFilters)
    extends DefaultHttpRequestHandler(webCommands,
                                      optDevContext,
                                      router,
                                      errorHandler,
                                      configuration,
                                      filters) { 
...
ignasi35 pushed a commit to ignasi35/play-samples that referenced this issue May 20, 2020
@dwijnand
Merge remote-tracking branch 'play-java-ebean-example/2.6.x' into 2.6.x
ff17d4f 
* play-java-ebean-example/2.6.x: (52 commits)
  Nest play-java-ebean-example
  Updated with template-control on 2019-02-13T20:25:39.252Z (playframework#96)
  Upgrade branch 2.6.x using TemplateControl (playframework#94)
  Upgrade branch 2.6.x using TemplateControl (playframework#93)
  Upgrade branch 2.6.x using TemplateControl (playframework#92)
  Updated with template-control on 2019-01-08T14:44:41.376Z (playframework#89)
  Upgrade branch 2.6.x using TemplateControl (playframework#85)
  Upgrade branch 2.6.x using TemplateControl (playframework#83)
  Upgrade branch 2.6.x using TemplateControl (playframework#79)
  Updated with template-control on 2018-09-11T20:14:50.116Z (playframework#77)
  Updated with template-control on 2018-08-20T20:37:13.842Z (playframework#76)
  Updated with template-control on 2018-07-19T01:58:55.623Z (playframework#74)
  Updated with template-control on 2018-07-16T18:38:45.357Z (playframework#73)
  Upgrade branch 2.6.x using TemplateControl (playframework#72)
  Updated with template-control on 2018-05-27T23:54:09.409Z (playframework#71)
  Updated with template-control on 2018-04-06T19:34:58.195Z (playframework#68)
  Updated with template-control on 2018-03-02T18:56:28.219Z (playframework#67)
  Updated with template-control on 2018-01-11T21:32:27.151Z (playframework#64)
  Fix cross build to sbt 1.1.0 (playframework#63)
  Updated with template-control on 2018-01-09T20:17:10.839Z (playframework#62)
  ...
ignasi35 pushed a commit to ignasi35/play-samples that referenced this issue May 20, 2020
@dwijnand
Merge remote-tracking branch 'play-java-websocket-example/2.6.x' into…
3a42d9c 
… 2.6.x

* play-java-websocket-example/2.6.x: (83 commits)
  Nest play-java-websocket-example
  Updated with template-control on 2019-02-13T20:25:39.721Z (playframework#100)
  Upgrade branch 2.6.x using TemplateControl (playframework#96)
  Upgrade branch 2.6.x using TemplateControl (playframework#94)
  Upgrade branch 2.6.x using TemplateControl (playframework#93)
  Updated with template-control on 2019-01-08T14:44:42.192Z (playframework#90)
  Updated with template-control on 2019-01-04T17:13:23.935Z (playframework#85)
  Upgrade branch 2.6.x using TemplateControl (playframework#84)
  Upgrade branch 2.6.x using TemplateControl (playframework#81)
  Updated with template-control on 2018-09-11T20:14:50.523Z (playframework#79)
  Updated with template-control on 2018-08-20T20:37:13.896Z (playframework#78)
  Updated with template-control on 2018-07-19T01:58:55.842Z (playframework#76)
  Updated with template-control on 2018-07-16T18:38:45.656Z (playframework#75)
  Upgrade branch 2.6.x using TemplateControl (playframework#74)
  Updated with template-control on 2018-05-27T23:54:09.712Z (playframework#73)
  Updated with template-control on 2018-04-06T19:34:58.514Z (playframework#71)
  Updated with template-control on 2018-03-02T18:56:28.527Z (playframework#70)
  Upgrade branch 2.6.x using TemplateControl (playframework#69)
  Fix cross build to sbt 1.1.0 (playframework#68)
  Upgrade branch 2.6.x using TemplateControl (playframework#67)
  ...
ignasi35 pushed a commit to ignasi35/play-samples that referenced this issue May 20, 2020
@dwijnand
Merge remote-tracking branch 'play-scala-anorm-example/2.6.x' into 2.6.x
18b40b7 
* play-scala-anorm-example/2.6.x: (68 commits)
  Nest play-scala-anorm-example
  Updated with template-control on 2019-02-13T20:25:39.764Z (playframework#105)
  Upgrade branch 2.6.x using TemplateControl (playframework#102)
  Upgrade branch 2.6.x using TemplateControl (playframework#101)
  Upgrade branch 2.6.x using TemplateControl (playframework#100)
  Updated with template-control on 2019-01-08T14:44:41.925Z (playframework#98)
  Updated with template-control on 2019-01-04T17:13:23.631Z (playframework#95)
  Fix deprecated WithResult.fold method usage (playframework#94)
  Upgrade branch 2.6.x using TemplateControl (playframework#93)
  Upgrade branch 2.6.x using TemplateControl (playframework#90)
  Updated with template-control on 2018-09-11T20:14:50.057Z (playframework#89)
  Fix cross build to sbt 1.1.0 (playframework#76)
  Updated with template-control on 2018-07-19T01:58:55.836Z (playframework#87)
  Updated with template-control on 2018-07-16T18:38:45.458Z (playframework#86)
  Upgrade branch 2.6.x using TemplateControl (playframework#85)
  Updated with template-control on 2018-05-27T23:54:09.813Z (playframework#84)
  Updated with template-control on 2018-04-06T19:34:57.924Z (playframework#80)
  Update the README (playframework#82)
  Upgrade Anorm dependency and usage (playframework#81)
  link to playframework version of anorm (playframework#79)
  ...
ignasi35 pushed a commit to ignasi35/play-samples that referenced this issue May 20, 2020
@dwijnand
Merge remote-tracking branch 'play-scala-rest-api-example/2.6.x' into…
a274615 
… 2.6.x

* play-scala-rest-api-example/2.6.x: (73 commits)
  Nest play-scala-rest-api-example
  Updated with template-control on 2019-02-13T20:25:39.695Z (playframework#140)
  Updated with template-control on 2019-02-01T10:40:33.469Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-17T15:10:57.883Z   /.mergify.yml:     wrote /.mergify.yml
  Updated with template-control on 2019-01-16T12:08:46.083Z   /LICENSE:     wrote /LICENSE   /NOTICE:     wrote /NOTICE   /.mergify.yml:     wrote /.mergify.yml
  Upgrade branch 2.6.x using TemplateControl (playframework#133)
  Updated with template-control on 2019-01-04T17:13:24.057Z (playframework#128)
  Upgrade branch 2.6.x using TemplateControl (playframework#127)
  Updated with template-control on 2018-10-08T19:11:41.384Z   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.20")   **build.gradle:     def playVersion = "2.6.20"
  Updated with template-control on 2018-09-11T20:14:50.615Z (playframework#122)
  Updated with template-control on 2018-08-20T20:37:13.956Z (playframework#121)
  Updated with template-control on 2018-07-19T01:58:56.043Z (playframework#119)
  Updated with template-control on 2018-07-16T18:38:45.676Z (playframework#118)
  Upgrade branch 2.6.x using TemplateControl (playframework#117)
  sbt 1.1.6 (playframework#116)
  Fix format issues (playframework#115)
  Update documentation to reflect Play 2.6 changes (playframework#114)
  Use @ref to link to other .md pages (playframework#93)
  Revert gatling version change and update Scala 2.12
  Updated with template-control on 2018-05-27T23:54:09.491Z   **build.sbt:     libraryDependencies += "io.gatling.highcharts" % "gatling-charts-highcharts" % "2.3.1" % Test   **build.sbt:     libraryDependencies += "io.gatling" % "gatling-test-framework" % "2.3.1" % Test   **/plugins.sbt:     addSbtPlugin("com.typesafe.play" % "sbt-plugin" % "2.6.15")   **build.gradle:     def playVersion = "2.6.15"
  ...
ignasi35 pushed a commit to ignasi35/play-samples that referenced this issue May 20, 2020
@dwijnand
Merge remote-tracking branch 'play-scala-secure-session-example/2.6.x…
fff317a 
…' into 2.6.x

* play-scala-secure-session-example/2.6.x: (70 commits)
  Nest play-scala-secure-session-example
  Updated with template-control on 2019-02-13T20:17:46.435Z (playframework#95)
  Updated with template-control on 2019-02-01T10:40:32.758Z (playframework#93)
  Upgrade branch 2.6.x using TemplateControl (playframework#92)
  Upgrade branch 2.6.x using TemplateControl (playframework#91)
  Upgrade branch 2.6.x using TemplateControl (playframework#89)
  Upgrade branch 2.6.x using TemplateControl (playframework#82)
  Upgrade branch 2.6.x using TemplateControl (playframework#81)
  adds mergify file (playframework#79)
  Upgrade branch 2.6.x using TemplateControl (playframework#77)
  Updated with template-control on 2018-08-20T20:37:13.861Z (playframework#71)
  Updated with template-control on 2018-07-19T01:58:55.998Z (playframework#69)
  Updated with template-control on 2018-07-16T18:38:45.458Z (playframework#68)
  Upgrade branch 2.6.x using TemplateControl (playframework#66)
  Updated with template-control on 2018-05-27T23:54:09.617Z (playframework#65)
  Updated with template-control on 2018-04-06T19:34:58.475Z (playframework#63)
  Updated with template-control on 2018-03-02T18:56:28.210Z (playframework#62)
  Upgrade branch 2.6.x using TemplateControl (playframework#61)
  Fix cross build to sbt 1.1.0 (playframework#60)
  Upgrade branch 2.6.x using TemplateControl (playframework#59)
  ...
ignasi35 pushed a commit to ignasi35/play-samples that referenced this issue May 20, 2020
@dwijnand
Merge remote-tracking branch 'play-scala-starter-example/2.6.x' into …
62fd6cb 
…2.6.x

* play-scala-starter-example/2.6.x: (68 commits)
  Nest play-scala-starter-example
  Updated with template-control on 2019-02-13T20:25:39.621Z (playframework#120)
  Change user action from clicking to refreshing (playframework#99)
  Upgrade branch 2.6.x using TemplateControl (playframework#117)
  Upgrade branch 2.6.x using TemplateControl (playframework#116)
  Upgrade branch 2.6.x using TemplateControl (playframework#115)
  Updated with template-control on 2019-01-08T14:44:42.057Z (playframework#113)
  Updated with template-control on 2019-01-04T17:13:24.100Z (playframework#108)
  Upgrade branch 2.6.x using TemplateControl (playframework#105)
  Updated with template-control on 2018-11-16T14:25:15.398Z (playframework#103)
  Remove jdk 9 & 10 (playframework#97)
  Upgrade to Scala 2.12.7 (playframework#95)
  Improve README (playframework#96)
  Upgrade branch 2.6.x using TemplateControl (playframework#94)
  Updated with template-control on 2018-09-11T20:14:50.648Z (playframework#93)
  Updated with template-control on 2018-08-20T20:37:14.070Z (playframework#92)
  Updated with template-control on 2018-07-19T01:58:56.055Z (playframework#90)
  Updated with template-control on 2018-07-16T18:38:45.679Z (playframework#89)
  Add jdk 10 & 11 to Travis build (playframework#86)
  Scala 2.12.6 (playframework#88)
  ...
ignasi35 pushed a commit to ignasi35/play-samples that referenced this issue May 20, 2020
@dwijnand
Merge remote-tracking branch 'play-scala-tls-example/2.6.x' into 2.6.x
69725ea 
* play-scala-tls-example/2.6.x: (53 commits)
  Nest play-scala-tls-example
  Updated with template-control on 2019-02-13T20:25:39.799Z (playframework#100)
  Upgrade branch 2.6.x using TemplateControl (playframework#98)
  Upgrade branch 2.6.x using TemplateControl (playframework#97)
  Upgrade branch 2.6.x using TemplateControl (playframework#96)
  Updated with template-control on 2019-01-08T14:44:41.961Z (playframework#93)
  Updated with template-control on 2019-01-04T21:47:52.378Z (playframework#87)
  Make Travis CI fast_finish
  Upgrade branch 2.6.x using TemplateControl (playframework#83)
  remove array syntax on label conditional check
  mergify with squash (playframework#79)
  minor mergify improvements (playframework#78)
  mergify file (playframework#77)
  AkkaHttpServer.Context - removed usage of deprecated API (playframework#76)
  Upgrade branch 2.6.x using TemplateControl (playframework#71)
  Upgrade branch 2.6.x using TemplateControl (playframework#55)
  Fix cross build to sbt 1.1.0 (playframework#54)
  Upgrade branch 2.6.x using TemplateControl (playframework#53)
  Upgrade branch 2.6.x using TemplateControl (playframework#51)
  Updated with template-control on 2017-12-21T20:59:17.421Z (playframework#50)
  ...
@mkurz
Copy link
Member

mkurz commented Mar 4, 2023

There is an open issue about formatting each sample project using scalafmt/javafmt: #118

@mkurz mkurz closed this as completed Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkurz @jeremyjjbrown