Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing @enduml gives wrong error: "No @startuml found" #32

Open
fuhrmanator opened this issue Dec 4, 2019 · 6 comments
Open

missing @enduml gives wrong error: "No @startuml found" #32

fuhrmanator opened this issue Dec 4, 2019 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fuhrmanator
Copy link

If a piped text without @enduml is sent to the .jar, it creates an error image with a misleading error "No @startuml found". We found this in the VSCode plug-in, qjebbs/vscode-plantuml#265

Here's how to reproduce it:

$ echo -e "@startuml\nAlice -> Bob: test\n" | java -Djava.awt.headless=true -jar plantuml.jar -v -pipe > nostart.png

image

The error (for newbies) is confusing. Could it be fixed to report more info, e.g., "No @startuml/@enduml found"?

@evantill evantill added enhancement New feature or request good first issue Good for newcomers labels Mar 19, 2023
@arnaudroques
Copy link
Contributor

The message is now "No diagram found".
Not sure this is more useful :-)

@arnaudroques arnaudroques transferred this issue from plantuml/plantuml Mar 20, 2023
@The-Lum
Copy link

The-Lum commented Jun 5, 2024

@fuhrmanator
Copy link
Author

Sounds great! I can't see the test logs (expired) but I'm curious what the error says now.

@The-Lum
Copy link

The-Lum commented Jun 6, 2024

Now [since Jul 29, 2021] there is no error...

Plantuml adds automaticaly the @enduml...

Enjoy,
Regards,
Th.

@fuhrmanator
Copy link
Author

Plantuml adds automaticaly the @enduml

Someone might be disappointed to find out that their corrupted diagram (especially when it's generated code) doesn't produce an error.

@The-Lum
Copy link

The-Lum commented Jun 7, 2024

FYI this enhancement was here since Jul 29, 2021.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants