-
Notifications
You must be signed in to change notification settings - Fork 1.1k
IntelliJ live templates for AsciiDoc #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We would have to ask the original author, @stawirej. It is quite possible that there isn't really a specific reason, but that things just happened to end up this way. Are there any conceivable downsideds to removing the constraint? Of not, I could update the |
I haven't found any downsides yet. |
Side note: https://github.com/plantuml-stdlib/C4-PlantUML?tab=readme-ov-file#prerequisites mentions PlantUML integration as a prerequiste. The templates work just fine using the IntelliJ AsciiDoc Plugin instead. |
I'm guessing that the AsciiDoc integration comes with its own PlantUML. We could update the docs to reflect this, though. |
Hi @marcelstoer, What I found out is that https://github.com/asciidoctor/asciidoctor-intellij-plugin has already a PlantUML support and therefore I assume you don't need the PlantUML integration anymore. I don't have IntelliJ on my machine. Can you
I would then merge your PR. Thank you |
I noticed that the provided IntelliJ live templates exclude the use in AsciiDoc files.
I wonder why that is.
PlantUML diagrams in AsciiDoc files is a perfectly fine use case in my opinion. Hence, I removed the above constraint from my
c4.xml
.The text was updated successfully, but these errors were encountered: