Skip to content

IntelliJ live templates for AsciiDoc #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marcelstoer opened this issue Mar 18, 2025 · 5 comments · Fixed by #392
Closed

IntelliJ live templates for AsciiDoc #388

marcelstoer opened this issue Mar 18, 2025 · 5 comments · Fixed by #392
Milestone

Comments

@marcelstoer
Copy link
Contributor

I noticed that the provided IntelliJ live templates exclude the use in AsciiDoc files.

<option name="AsciiDoc" value="false" />

I wonder why that is.

PlantUML diagrams in AsciiDoc files is a perfectly fine use case in my opinion. Hence, I removed the above constraint from my c4.xml.

@Potherca
Copy link
Member

I wonder why that is.

We would have to ask the original author, @stawirej.

It is quite possible that there isn't really a specific reason, but that things just happened to end up this way.

Are there any conceivable downsideds to removing the constraint? Of not, I could update the .zip file.

@marcelstoer
Copy link
Contributor Author

I haven't found any downsides yet.

@marcelstoer
Copy link
Contributor Author

Side note: https://github.com/plantuml-stdlib/C4-PlantUML?tab=readme-ov-file#prerequisites mentions PlantUML integration as a prerequiste. The templates work just fine using the IntelliJ AsciiDoc Plugin instead.

@Potherca
Copy link
Member

I'm guessing that the AsciiDoc integration comes with its own PlantUML. We could update the docs to reflect this, though.

@kirchsth
Copy link
Member

kirchsth commented Apr 6, 2025

Hi @marcelstoer,

What I found out is that https://github.com/asciidoctor/asciidoctor-intellij-plugin has already a PlantUML support and therefore I assume you don't need the PlantUML integration anymore.

I don't have IntelliJ on my machine.

Can you

  • upload a new version of the *.zip without the <option name="AsciiDoc" value="false" />

  • retest it only with the PlantUML Integration plugin too
    (without your used AsciiDoc Integration plugin; I assume you use this)

  • and add your used configuration as an alternative prerequisite to the README.md?

I would then merge your PR.

Thank you
Helmut

marcelstoer added a commit to marcelstoer/C4-PlantUML that referenced this issue Apr 7, 2025
marcelstoer added a commit to marcelstoer/C4-PlantUML that referenced this issue May 11, 2025
@kirchsth kirchsth added this to the v2.12.0 milestone May 12, 2025
@kirchsth kirchsth pinned this issue Jun 4, 2025
@kirchsth kirchsth unpinned this issue Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants