Unauthenticated client accepts target without '//'

- When importing an installation or configuring authentication a bare
hostname can be provided (defaulting to HTTPS)

[#149483797]

Author: acrmp

network/unauthenticated_client.go

@@ -6,6 +6,7 @@ import (
 	"net"
 	"net/http"
 	"net/url"
+	"strings"
 	"time"
 )
 
@@ -38,7 +39,13 @@ func NewUnauthenticatedClient(target string, insecureSkipVerify bool, requestTim
 }
 
 func (c UnauthenticatedClient) Do(request *http.Request) (*http.Response, error) {
-	targetURL, err := url.Parse(c.target)
+
+	candidateURL := c.target
+	if !strings.Contains(candidateURL, "//") {
+		candidateURL = fmt.Sprintf("//%s", candidateURL)
+	}
+
+	targetURL, err := url.Parse(candidateURL)
 	if err != nil {
 		return nil, fmt.Errorf("could not parse target url: %s", err)
 	}

network/unauthenticated_client_test.go

@@ -68,7 +68,7 @@ var _ = Describe("UnauthenticatedClient", func() {
 				Expect(err).NotTo(HaveOccurred())
 
 				noScheme.Scheme = ""
-				finalURL := noScheme.String()
+				finalURL := strings.Replace(noScheme.String(), "//", "", 1)
 
 				client := network.NewUnauthenticatedClient(finalURL, true, time.Duration(30)*time.Second)
 				Expect(err).NotTo(HaveOccurred())
@@ -89,7 +89,7 @@ var _ = Describe("UnauthenticatedClient", func() {
 				It("returns an error", func() {
 					client := network.NewUnauthenticatedClient("%%%", false, time.Duration(30)*time.Second)
 					_, err := client.Do(&http.Request{})
-					Expect(err).To(MatchError("could not parse target url: parse %%%: invalid URL escape \"%%%\""))
+					Expect(err).To(MatchError("could not parse target url: parse //%%%: invalid URL escape \"%%%\""))
 				})
 			})