Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unnecessary methods and files for k8s plugin #5675

Merged
merged 9 commits into from
Mar 17, 2025

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Mar 17, 2025

What this PR does:

As title. I removed some codes for the k8s plugin implemented with the package pkg/plugin directly.

replaced some methods

removed files

Why we need it:

We want to implement plugins with SDK.

Which issue(s) this PR fixes:

Part of #4980 #5006

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <[email protected]>
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 70.37037% with 8 lines in your changes missing coverage. Please review.

Project coverage is 25.65%. Comparing base (20577c0) to head (fde65bb).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...app/pipedv1/plugin/kubernetes/deployment/plugin.go 0.00% 5 Missing and 1 partial ⚠️
.../pipedv1/plugin/kubernetes/deployment/determine.go 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5675      +/-   ##
==========================================
+ Coverage   25.60%   25.65%   +0.05%     
==========================================
  Files         478      474       -4     
  Lines       51307    50905     -402     
==========================================
- Hits        13135    13060      -75     
+ Misses      37167    36854     -313     
+ Partials     1005      991      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ffjlabo added 8 commits March 17, 2025 16:36
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
@ffjlabo ffjlabo force-pushed the cleanup-unnecessary-methods-for-k8s-plugin branch from f62a3a7 to fde65bb Compare March 17, 2025 07:37
@ffjlabo ffjlabo marked this pull request as ready for review March 17, 2025 07:48
@ffjlabo ffjlabo changed the title Cleanup unnecessary methods for k8s plugin Cleanup unnecessary methods and files for k8s plugin Mar 17, 2025
@khanhtc1202 khanhtc1202 merged commit 57c48c1 into master Mar 17, 2025
18 checks passed
@khanhtc1202 khanhtc1202 deleted the cleanup-unnecessary-methods-for-k8s-plugin branch March 17, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants