-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup unnecessary methods and files for k8s plugin #5675
Merged
khanhtc1202
merged 9 commits into
master
from
cleanup-unnecessary-methods-for-k8s-plugin
Mar 17, 2025
Merged
Cleanup unnecessary methods and files for k8s plugin #5675
khanhtc1202
merged 9 commits into
master
from
cleanup-unnecessary-methods-for-k8s-plugin
Mar 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoshiki Fujikane <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5675 +/- ##
==========================================
+ Coverage 25.60% 25.65% +0.05%
==========================================
Files 478 474 -4
Lines 51307 50905 -402
==========================================
- Hits 13135 13060 -75
+ Misses 37167 36854 -313
+ Partials 1005 991 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
f62a3a7
to
fde65bb
Compare
t-kikuc
approved these changes
Mar 17, 2025
Warashi
approved these changes
Mar 17, 2025
khanhtc1202
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
As title. I removed some codes for the k8s plugin implemented with the package
pkg/plugin
directly.replaced some methods
removed files
Why we need it:
We want to implement plugins with SDK.
Which issue(s) this PR fixes:
Part of #4980 #5006
Does this PR introduce a user-facing change?: