Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Add PipedID and ApplicationName fields to GetLivestateRequest #5670

Merged
merged 2 commits into from
Mar 17, 2025

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Mar 17, 2025

What this PR does:

as title

Why we need it:

We need these to implement livestate/driftdetection feature

Which issue(s) this PR fixes:

Follows #5668
Part of #4980 #5363

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@Warashi Warashi changed the title Add PipedID and ApplicationName fields to GetLivestateRequest [SDK] Add PipedID and ApplicationName fields to GetLivestateRequest Mar 17, 2025
…cationID, and ApplicationName

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
@Warashi Warashi marked this pull request as ready for review March 17, 2025 02:24
@Warashi Warashi enabled auto-merge (squash) March 17, 2025 02:24
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Warashi Warashi merged commit 7b4c9bd into master Mar 17, 2025
16 checks passed
@Warashi Warashi deleted the livestate-more-info-sdk branch March 17, 2025 02:28
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.56%. Comparing base (5ce218d) to head (b18aa5e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5670      +/-   ##
==========================================
- Coverage   25.57%   25.56%   -0.01%     
==========================================
  Files         478      478              
  Lines       51240    51242       +2     
==========================================
- Hits        13105    13101       -4     
- Misses      37130    37136       +6     
  Partials     1005     1005              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants