Refactor to remove unnecessary error in the return values (#5617)

Signed-off-by: Yoshiki Fujikane <[email protected]>

Author: ffjlabo

pkg/app/pipedv1/plugin/kubernetes/deployment/determine.go

@@ -47,7 +47,7 @@ func parseContainerImage(image string) (img containerImage) {
 
 // determineVersions decides artifact versions of an application.
 // It finds all container images that are being specified in the workload manifests then returns their names and tags.
-func determineVersions(manifests []provider.Manifest) ([]*model.ArtifactVersion, error) {
+func determineVersions(manifests []provider.Manifest) []*model.ArtifactVersion {
 	imageMap := map[string]struct{}{}
 	for _, m := range manifests {
 		for _, c := range provider.FindContainerImages(m) {
@@ -66,7 +66,7 @@ func determineVersions(manifests []provider.Manifest) ([]*model.ArtifactVersion,
 		})
 	}
 
-	return versions, nil
+	return versions
 }
 
 // findManifests returns the manifests that have the specified kind and name.

pkg/app/pipedv1/plugin/kubernetes/deployment/determine_test.go

@@ -100,11 +100,12 @@ func TestParseContainerImage(t *testing.T) {
 	}
 }
 func TestDetermineVersions(t *testing.T) {
+	t.Parallel()
+
 	tests := []struct {
 		name      string
 		manifests []string
 		want      []*model.ArtifactVersion
-		wantErr   bool
 	}{
 		{
 			name: "single manifest with one container",
@@ -247,8 +248,7 @@ spec:
     spec: {}
 `,
 			},
-			want:    []*model.ArtifactVersion{},
-			wantErr: false,
+			want: []*model.ArtifactVersion{},
 		},
 		{
 			name: "manifest with invalid containers field -- skipped",
@@ -265,23 +265,18 @@ spec:
         - "invalid-containers-field"
 `,
 			},
-			wantErr: false,
 		},
 	}
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+
 			var manifests []provider.Manifest
 			for _, data := range tt.manifests {
 				manifests = append(manifests, mustUnmarshalYAML[provider.Manifest](t, []byte(strings.TrimSpace(data))))
 			}
-			got, err := determineVersions(manifests)
-			if tt.wantErr {
-				require.Error(t, err)
-				return
-			} else {
-				require.NoError(t, err)
-			}
+			got := determineVersions(manifests)
 			assert.ElementsMatch(t, tt.want, got)
 		})
 	}

pkg/app/pipedv1/plugin/kubernetes/deployment/server.go

@@ -145,13 +145,8 @@ func (a *DeploymentService) DetermineVersions(ctx context.Context, request *depl
 		return nil, status.Error(codes.Internal, err.Error())
 	}
 
-	versions, err := determineVersions(manifests)
-	if err != nil {
-		return nil, status.Error(codes.Internal, err.Error())
-	}
-
 	return &deployment.DetermineVersionsResponse{
-		Versions: versions,
+		Versions: determineVersions(manifests),
 	}, nil
 }