Skip to content

Commit ad00a56

Browse files
authored
Rename PipelineSyncPlugin -> StagePlugin (missed to rename) (#5593)
Signed-off-by: t-kikuc <[email protected]>
1 parent 7b78a17 commit ad00a56

File tree

7 files changed

+28
-28
lines changed

7 files changed

+28
-28
lines changed

pkg/app/pipedv1/plugin/example/main.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import (
2121
)
2222

2323
func main() {
24-
sdk.RegisterPipelineSyncPlugin(&plugin{})
24+
sdk.RegisterStagePlugin(&plugin{})
2525

2626
if err := sdk.Run(); err != nil {
2727
log.Fatalln(err)

pkg/app/pipedv1/plugin/example/plugin.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -34,17 +34,17 @@ func (p *plugin) Version() string {
3434
return "0.0.1"
3535
}
3636

37-
// BuildPipelineSyncStages implements sdk.PipelineSyncPlugin.
37+
// BuildPipelineSyncStages implements sdk.StagePlugin.
3838
func (p *plugin) BuildPipelineSyncStages(context.Context, *config, *sdk.BuildPipelineSyncStagesInput) (*sdk.BuildPipelineSyncStagesResponse, error) {
3939
return &sdk.BuildPipelineSyncStagesResponse{}, nil
4040
}
4141

42-
// ExecuteStage implements sdk.PipelineSyncPlugin.
42+
// ExecuteStage implements sdk.StagePlugin.
4343
func (p *plugin) ExecuteStage(context.Context, *config, sdk.DeployTargetsNone, *sdk.ExecuteStageInput) (*sdk.ExecuteStageResponse, error) {
4444
return &sdk.ExecuteStageResponse{}, nil
4545
}
4646

47-
// FetchDefinedStages implements sdk.PipelineSyncPlugin.
47+
// FetchDefinedStages implements sdk.StagePlugin.
4848
func (p *plugin) FetchDefinedStages() []string {
4949
return []string{"EXAMPLE_PLAN", "EXAMPLE_APPLY"}
5050
}

pkg/app/pipedv1/plugin/kubernetes_multicluster/main.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import (
2121
)
2222

2323
func main() {
24-
sdk.RegisterPipelineSyncPlugin(&plugin{})
24+
sdk.RegisterStagePlugin(&plugin{})
2525

2626
if err := sdk.Run(); err != nil {
2727
log.Fatalln(err)

pkg/app/pipedv1/plugin/kubernetes_multicluster/plugin.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -34,17 +34,17 @@ func (p *plugin) Version() string {
3434
return "0.0.1"
3535
}
3636

37-
// BuildPipelineSyncStages implements sdk.PipelineSyncPlugin.
37+
// BuildPipelineSyncStages implements sdk.StagePlugin.
3838
func (p *plugin) BuildPipelineSyncStages(context.Context, *config, *sdk.BuildPipelineSyncStagesInput) (*sdk.BuildPipelineSyncStagesResponse, error) {
3939
return &sdk.BuildPipelineSyncStagesResponse{}, nil
4040
}
4141

42-
// ExecuteStage implements sdk.PipelineSyncPlugin.
42+
// ExecuteStage implements sdk.StagePlugin.
4343
func (p *plugin) ExecuteStage(context.Context, *config, sdk.DeployTargetsNone, *sdk.ExecuteStageInput) (*sdk.ExecuteStageResponse, error) {
4444
return &sdk.ExecuteStageResponse{}, nil
4545
}
4646

47-
// FetchDefinedStages implements sdk.PipelineSyncPlugin.
47+
// FetchDefinedStages implements sdk.StagePlugin.
4848
func (p *plugin) FetchDefinedStages() []string {
4949
return []string{"K8S_SYNC"}
5050
}

pkg/app/pipedv1/plugin/wait/main.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import (
2121
)
2222

2323
func main() {
24-
sdk.RegisterPipelineSyncPlugin(&plugin{})
24+
sdk.RegisterStagePlugin(&plugin{})
2525

2626
if err := sdk.Run(); err != nil {
2727
log.Fatalln(err)

pkg/app/pipedv1/plugin/wait/plugin.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ func (p *plugin) Version() string {
3636
return "0.0.1" // TODO
3737
}
3838

39-
// BuildPipelineSyncStages implements sdk.PipelineSyncPlugin.
39+
// BuildPipelineSyncStages implements sdk.StagePlugin.
4040
func (p *plugin) BuildPipelineSyncStages(ctx context.Context, _ sdk.ConfigNone, input *sdk.BuildPipelineSyncStagesInput) (*sdk.BuildPipelineSyncStagesResponse, error) {
4141
stages := make([]sdk.PipelineStage, 0, len(input.Request.Stages))
4242
for _, rs := range input.Request.Stages {
@@ -55,15 +55,15 @@ func (p *plugin) BuildPipelineSyncStages(ctx context.Context, _ sdk.ConfigNone,
5555
}, nil
5656
}
5757

58-
// ExecuteStage implements sdk.PipelineSyncPlugin.
58+
// ExecuteStage implements sdk.StagePlugin.
5959
func (p *plugin) ExecuteStage(ctx context.Context, _ sdk.ConfigNone, _ sdk.DeployTargetsNone, input *sdk.ExecuteStageInput) (*sdk.ExecuteStageResponse, error) {
6060
status := p.executeWait(ctx, input)
6161
return &sdk.ExecuteStageResponse{
6262
Status: status,
6363
}, nil
6464
}
6565

66-
// FetchDefinedStages implements sdk.PipelineSyncPlugin.
66+
// FetchDefinedStages implements sdk.StagePlugin.
6767
func (p *plugin) FetchDefinedStages() []string {
6868
return []string{stageWait}
6969
}

pkg/plugin/sdk/deployment.go

+16-16
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,10 @@ func RegisterDeploymentPlugin[Config, DeployTargetConfig any](plugin DeploymentP
9898
deploymentServiceServer = &DeploymentPluginServiceServer[Config, DeployTargetConfig]{base: plugin}
9999
}
100100

101-
// RegisterPipelineSyncPlugin registers the given pipeline sync plugin.
101+
// RegisterStagePlugin registers the given stage plugin.
102102
// It will be used when running the piped.
103-
func RegisterPipelineSyncPlugin[Config, DeployTargetConfig any](plugin StagePlugin[Config, DeployTargetConfig]) {
104-
deploymentServiceServer = &PipelineSyncPluginServiceServer[Config, DeployTargetConfig]{base: plugin}
103+
func RegisterStagePlugin[Config, DeployTargetConfig any](plugin StagePlugin[Config, DeployTargetConfig]) {
104+
deploymentServiceServer = &StagePluginServiceServer[Config, DeployTargetConfig]{base: plugin}
105105
}
106106

107107
type logPersister interface {
@@ -193,8 +193,8 @@ func (s *DeploymentPluginServiceServer[Config, DeployTargetConfig]) ExecuteStage
193193
return executeStage(ctx, s.base, &s.config, nil, client, request, s.logger) // TODO: pass the deployTargets
194194
}
195195

196-
// PipelineSyncPluginServiceServer is the gRPC server that handles requests from the piped.
197-
type PipelineSyncPluginServiceServer[Config, DeployTargetConfig any] struct {
196+
// StagePluginServiceServer is the gRPC server that handles requests from the piped.
197+
type StagePluginServiceServer[Config, DeployTargetConfig any] struct {
198198
deployment.UnimplementedDeploymentServiceServer
199199
commonFields
200200

@@ -203,25 +203,25 @@ type PipelineSyncPluginServiceServer[Config, DeployTargetConfig any] struct {
203203
}
204204

205205
// Name returns the name of the plugin.
206-
func (s *PipelineSyncPluginServiceServer[Config, DeployTargetConfig]) Name() string {
206+
func (s *StagePluginServiceServer[Config, DeployTargetConfig]) Name() string {
207207
return s.base.Name()
208208
}
209209

210210
// Version returns the version of the plugin.
211-
func (s *PipelineSyncPluginServiceServer[Config, DeployTargetConfig]) Version() string {
211+
func (s *StagePluginServiceServer[Config, DeployTargetConfig]) Version() string {
212212
return s.base.Version()
213213
}
214214

215215
// Register registers the server to the given gRPC server.
216-
func (s *PipelineSyncPluginServiceServer[Config, DeployTargetConfig]) Register(server *grpc.Server) {
216+
func (s *StagePluginServiceServer[Config, DeployTargetConfig]) Register(server *grpc.Server) {
217217
deployment.RegisterDeploymentServiceServer(server, s)
218218
}
219219

220-
func (s *PipelineSyncPluginServiceServer[Config, DeployTargetConfig]) setCommonFields(fields commonFields) {
220+
func (s *StagePluginServiceServer[Config, DeployTargetConfig]) setCommonFields(fields commonFields) {
221221
s.commonFields = fields
222222
}
223223

224-
func (s *PipelineSyncPluginServiceServer[Config, DeployTargetConfig]) setConfig(bytes []byte) error {
224+
func (s *StagePluginServiceServer[Config, DeployTargetConfig]) setConfig(bytes []byte) error {
225225
if bytes == nil {
226226
return nil
227227
}
@@ -231,27 +231,27 @@ func (s *PipelineSyncPluginServiceServer[Config, DeployTargetConfig]) setConfig(
231231
return nil
232232
}
233233

234-
func (s *PipelineSyncPluginServiceServer[Config, DeployTargetConfig]) FetchDefinedStages(context.Context, *deployment.FetchDefinedStagesRequest) (*deployment.FetchDefinedStagesResponse, error) {
234+
func (s *StagePluginServiceServer[Config, DeployTargetConfig]) FetchDefinedStages(context.Context, *deployment.FetchDefinedStagesRequest) (*deployment.FetchDefinedStagesResponse, error) {
235235
return &deployment.FetchDefinedStagesResponse{Stages: s.base.FetchDefinedStages()}, nil
236236
}
237-
func (s *PipelineSyncPluginServiceServer[Config, DeployTargetConfig]) DetermineVersions(context.Context, *deployment.DetermineVersionsRequest) (*deployment.DetermineVersionsResponse, error) {
237+
func (s *StagePluginServiceServer[Config, DeployTargetConfig]) DetermineVersions(context.Context, *deployment.DetermineVersionsRequest) (*deployment.DetermineVersionsResponse, error) {
238238
return &deployment.DetermineVersionsResponse{}, nil
239239
}
240-
func (s *PipelineSyncPluginServiceServer[Config, DeployTargetConfig]) DetermineStrategy(context.Context, *deployment.DetermineStrategyRequest) (*deployment.DetermineStrategyResponse, error) {
240+
func (s *StagePluginServiceServer[Config, DeployTargetConfig]) DetermineStrategy(context.Context, *deployment.DetermineStrategyRequest) (*deployment.DetermineStrategyResponse, error) {
241241
return &deployment.DetermineStrategyResponse{Unsupported: true}, nil
242242
}
243-
func (s *PipelineSyncPluginServiceServer[Config, DeployTargetConfig]) BuildPipelineSyncStages(ctx context.Context, request *deployment.BuildPipelineSyncStagesRequest) (*deployment.BuildPipelineSyncStagesResponse, error) {
243+
func (s *StagePluginServiceServer[Config, DeployTargetConfig]) BuildPipelineSyncStages(ctx context.Context, request *deployment.BuildPipelineSyncStagesRequest) (*deployment.BuildPipelineSyncStagesResponse, error) {
244244
client := &Client{
245245
base: s.client,
246246
pluginName: s.Name(),
247247
}
248248

249249
return buildPipelineSyncStages(ctx, s.base, &s.config, client, request, s.logger) // TODO: pass the real client
250250
}
251-
func (s *PipelineSyncPluginServiceServer[Config, DeployTargetConfig]) BuildQuickSyncStages(context.Context, *deployment.BuildQuickSyncStagesRequest) (*deployment.BuildQuickSyncStagesResponse, error) {
251+
func (s *StagePluginServiceServer[Config, DeployTargetConfig]) BuildQuickSyncStages(context.Context, *deployment.BuildQuickSyncStagesRequest) (*deployment.BuildQuickSyncStagesResponse, error) {
252252
return nil, status.Errorf(codes.Unimplemented, "method BuildQuickSyncStages not implemented")
253253
}
254-
func (s *PipelineSyncPluginServiceServer[Config, DeployTargetConfig]) ExecuteStage(ctx context.Context, request *deployment.ExecuteStageRequest) (response *deployment.ExecuteStageResponse, _ error) {
254+
func (s *StagePluginServiceServer[Config, DeployTargetConfig]) ExecuteStage(ctx context.Context, request *deployment.ExecuteStageRequest) (response *deployment.ExecuteStageResponse, _ error) {
255255
lp := s.logPersister.StageLogPersister(request.GetInput().GetDeployment().GetId(), request.GetInput().GetStage().GetId())
256256
defer func() {
257257
// When termination signal received and the stage is not completed yet, we should not mark the log persister as completed.

0 commit comments

Comments
 (0)