Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crumbs are never current on POST #51

Open
benny-burkhart opened this issue Oct 4, 2021 · 1 comment · May be fixed by #50
Open

Crumbs are never current on POST #51

benny-burkhart opened this issue Oct 4, 2021 · 1 comment · May be fixed by #50
Assignees

Comments

@benny-burkhart
Copy link

Describe the problem

Crumbs are never current when rendered on a response to e.g. an HTTP Post.

Steps to reproduce the problem

Render the same crumbs in response to HTTP POST and GET request.

Actual behaviour

On GET, some crumbs can be current, and others not.
On POST, crumbs are never current.

Expected behaviour

Respect the behaviour configured using :match.

Describe your environment

  • OS version: MacOS Big Sur
  • Ruby version: 2.7
  • Loaf version: 0.10

This line here might be reasonably blunt:
https://github.com/piotrmurach/loaf/blob/v0.10.0/lib/loaf/view_extensions.rb#L69

Reckons? Thanks!

@piotrmurach piotrmurach linked a pull request Feb 21, 2022 that will close this issue
@piotrmurach
Copy link
Owner

Hi Benjamin,

Thanks for using loaf and reporting this issue.

This is considered in a pull request - #50

If you have any comments/thoughts let us know.

@piotrmurach piotrmurach self-assigned this Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants