-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add /*wakaru:missing*/
annotations to imports from missing modules/files
#77
Comments
I have been bothered by it for a while too 😄 My another idea on this would be to create a |
@pionxzh For a lot of my usages, I think that would end up creating more 'noise' than 'value', so if that were a feature you implemented, I think it would be best if it was optional/controllable via settings/a CLI flag/similar. |
I see. No worry. Then we can do the annotations first, |
Done with const foo = require(9527/* wakaru:missing */); |
@pionxzh Thanks! Just gave this a go, works well :) 🎉 |
I was just testing the new
webcrack
web IDE (Ref), and noticed that they annotate the unminified source to explicitly mention when a module being imported from is missing with/*webcrack:missing*/
. This would be a cool feature forwakaru
to support as well.You can see the full context of how I got to this unminified step on the issue I opened there (Ref), using this minified code (Ref), but here is what the annotation looks like in that unminified code:
webcrack
's180.js
with the/*webcrack:missing*/
annotation:Compared to
wakaru
's unminifiedmodule-180.js
without it:The text was updated successfully, but these errors were encountered: