Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11992] Add ServiceId creation and deletion api #11993

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

donghun-cho
Copy link
Contributor

@donghun-cho donghun-cho added this to the 4.0.0 milestone Jan 23, 2025
@donghun-cho donghun-cho self-assigned this Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 3.70370% with 234 lines in your changes missing coverage. Please review.

Project coverage is 34.91%. Comparing base (d31d099) to head (219b929).

Files with missing lines Patch % Lines
...com/navercorp/pinpoint/common/util/BytesUtils.java 0.00% 40 Missing ⚠️
...p/pinpoint/web/dao/hbase/id/HbaseServiceIdDao.java 0.00% 40 Missing ⚠️
...point/web/controller/id/ServiceInfoController.java 0.00% 39 Missing ⚠️
...pinpoint/web/dao/hbase/id/HbaseServiceInfoDao.java 0.00% 33 Missing ⚠️
...inpoint/web/service/id/ServiceInfoServiceImpl.java 0.00% 32 Missing ⚠️
...corp/pinpoint/common/server/bo/id/ServiceInfo.java 0.00% 15 Missing ⚠️
.../server/dao/hbase/mapper/id/ServiceInfoMapper.java 0.00% 14 Missing ⚠️
...on/server/dao/hbase/mapper/id/ServiceIdMapper.java 0.00% 8 Missing ⚠️
...ver/dao/hbase/mapper/id/ServiceInfoNameMapper.java 0.00% 8 Missing ⚠️
...erver/dao/hbase/mapper/id/ServiceIdNameMapper.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11993      +/-   ##
============================================
- Coverage     35.00%   34.91%   -0.09%     
+ Complexity    10972    10967       -5     
============================================
  Files          3828     3837       +9     
  Lines         91824    92060     +236     
  Branches       9714     9725      +11     
============================================
+ Hits          32141    32145       +4     
- Misses        57019    57247     +228     
- Partials       2664     2668       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant