fix(upsert_records): drop redundant 'id' key when '_id' present

When a record contains both '_id' and 'id', the SDK previously raised a
ValidationError. Per claim unified-bp-0007, '_id' must take precedence and
the bare 'id' key must be silently dropped. Apply the same fix to both
sync (Index) and async (AsyncIndex) codepaths.

Fixes CI-0056; honors unified-bp-0007.

Author: jhamon

pinecone/async_client/async_index.py

@@ -202,7 +202,7 @@ async def upsert_records(
             if "_id" not in r and "id" in r:
                 r["_id"] = r.pop("id")
             elif "_id" in r and "id" in r:
-                raise ValidationError(f"Record at index {i} cannot have both '_id' and 'id' fields")
+                del r["id"]  # _id wins; drop the redundant 'id' key
             resolved_id = r.get("_id")
             if not isinstance(resolved_id, str):
                 got = type(resolved_id).__name__

pinecone/index/__init__.py

@@ -531,7 +531,7 @@ def upsert_records(
             if "_id" not in r and "id" in r:
                 r["_id"] = r.pop("id")
             elif "_id" in r and "id" in r:
-                raise ValidationError(f"Record at index {i} cannot have both '_id' and 'id' fields")
+                del r["id"]  # _id wins; drop the redundant 'id' key
             resolved_id = r.get("_id")
             if not isinstance(resolved_id, str):
                 got = type(resolved_id).__name__

tests/integration/test_data_plane.py

@@ -2017,11 +2017,19 @@ def test_upsert_records_id_must_be_string() -> None:
         idx.upsert_records(namespace="ns", records=[{"_id": 123, "text": "hello"}])
 
 
-def test_upsert_records_both_id_fields_rejected() -> None:
-    """upsert_records raises ValidationError when record has both '_id' and 'id' fields."""
+@respx.mock
+def test_upsert_records_both_id_fields_strips_id() -> None:
+    """When both '_id' and 'id' are present, 'id' is dropped and '_id' is used."""
+    import json as _json
+
+    upsert_url = "https://my-index.svc.pinecone.io/records/namespaces/ns/upsert"
+    route = respx.post(upsert_url).mock(return_value=httpx.Response(201))
     idx = Index(host="my-index.svc.pinecone.io", api_key="test-key")
-    with pytest.raises(ValidationError, match="cannot have both '_id' and 'id'"):
-        idx.upsert_records(namespace="ns", records=[{"_id": "a", "id": "b", "text": "hello"}])
+    idx.upsert_records(namespace="ns", records=[{"_id": "wins", "id": "loses", "text": "hello"}])
+    body = route.calls.last.request.content.decode("utf-8")
+    parsed = _json.loads(body.strip())
+    assert parsed["_id"] == "wins"
+    assert "id" not in parsed
 
 
 # ---------------------------------------------------------------------------

tests/unit/test_async_upsert_records.py

@@ -116,15 +116,20 @@ async def test_async_upsert_records_keyword_only(self) -> None:
         with pytest.raises(TypeError):
             await idx.upsert_records([{"_id": "r1"}], "ns")  # type: ignore[misc]
 
+    @respx.mock
     @pytest.mark.anyio
-    async def test_async_upsert_records_both_id_fields_rejected(self) -> None:
-        """Records with both '_id' and 'id' fields raise ValidationError."""
+    async def test_async_upsert_records_both_id_fields_strips_id(self) -> None:
+        """When both '_id' and 'id' are present, 'id' is dropped and '_id' wins."""
+        route = respx.post(UPSERT_URL).mock(return_value=httpx.Response(201, content=b""))
         idx = _make_async_index()
-        with pytest.raises(ValidationError, match="cannot have both '_id' and 'id'"):
-            await idx.upsert_records(
-                namespace="test-ns",
-                records=[{"_id": "a", "id": "b", "text": "hello"}],
-            )
+        await idx.upsert_records(
+            namespace="test-ns",
+            records=[{"_id": "wins", "id": "loses", "text": "hello"}],
+        )
+        body = route.calls.last.request.content.decode("utf-8")
+        parsed = json.loads(body.strip())
+        assert parsed["_id"] == "wins"
+        assert "id" not in parsed
 
     @pytest.mark.anyio
     async def test_async_upsert_records_id_must_be_string(self) -> None:

tests/unit/test_upsert_records.py

@@ -139,14 +139,21 @@ def test_upsert_records_mixed_id_formats(self) -> None:
         assert parsed_1["_id"] == "r2"
         assert "id" not in parsed_1
 
-    def test_upsert_records_both_id_fields_rejected(self) -> None:
-        """Records with both '_id' and 'id' fields raise ValidationError."""
+    @respx.mock
+    def test_upsert_records_both_id_fields_strips_id(self) -> None:
+        """When both '_id' and 'id' are present, 'id' is dropped and '_id' wins."""
+        route = respx.post(UPSERT_URL).mock(
+            return_value=httpx.Response(201),
+        )
         idx = _make_index()
-        with pytest.raises(ValidationError, match="cannot have both '_id' and 'id'"):
-            idx.upsert_records(
-                namespace="test-ns",
-                records=[{"_id": "a", "id": "b", "text": "hello"}],
-            )
+        idx.upsert_records(
+            namespace="test-ns",
+            records=[{"_id": "wins", "id": "loses", "text": "hello"}],
+        )
+        body = route.calls.last.request.content.decode("utf-8")
+        parsed = json.loads(body.strip())
+        assert parsed["_id"] == "wins"
+        assert "id" not in parsed
 
     def test_upsert_records_id_must_be_string(self) -> None:
         """Records where '_id' is not a string raise ValidationError."""