Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade scorecard workflow pinned action versions #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carpasse
Copy link
Contributor

@carpasse carpasse commented Dec 19, 2024

Upgrade scorecard workflow pinned action versions to latest versions.

Issue expressjs/security-wg#2

@@ -32,12 +33,12 @@ jobs:

steps:
- name: "Checkout code"
uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the decision was made to not pin actions from GitHub itself, has this been changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn’t aware of that decision. The Pinned Dependencies check is classified as a Medium threat according to the Scorecard checks (reference).

@jonkoops Could you please share the documentation or context regarding where this decision was made?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember it was being discussed, but it seems to be formalized now, so consider this resolved.

@jonkoops
Copy link
Contributor

Might also be worth it to set up Dependabot to do these upgrades automatically in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants