Skip to content

Commit b34e938

Browse files
authored
feat: Remove group and label and add identity and identityType (#38)
1 parent 8e08b54 commit b34e938

File tree

12 files changed

+28
-107
lines changed

12 files changed

+28
-107
lines changed

apps/event-system/services/event-links/schema/create.schema.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,6 @@ import { createSchema } from '@libs-private/generic-schema/create.schema';
22

33
export const createLinkSchema = {
44
...createSchema,
5-
label: {
6-
type: 'string',
7-
},
8-
group: {
9-
type: 'string',
10-
},
115
ttl: {
126
type: 'number',
137
default: 2 * 1000 * 60 * 60, // 2 hours

libs-private/service-logic/generators/embedTokens.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ import {
55
import { generateId } from '../service-helper';
66

77
export const generateEmbedTokensRecord = async ({
8-
label,
9-
group,
108
ttl,
119
linkSettings,
1210
environment,
@@ -15,8 +13,6 @@ export const generateEmbedTokensRecord = async ({
1513
const sessionId = await generateId('session_id');
1614

1715
return {
18-
label,
19-
group,
2016
linkSettings,
2117
createdAt: Date.now(),
2218
createdDate: new Date(),

libs-private/service-logic/generators/events/eventLink.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import { generateId } from '@libs-private/utils';
44

55
export const generateEventLinkRecord = async ({
66
version = '1.0.0_04.44_18-04-2023T10-33-00',
7-
label,
8-
group,
7+
identity,
8+
identityType,
99
ttl,
1010
ownership,
1111
environment,
@@ -19,8 +19,8 @@ export const generateEventLinkRecord = async ({
1919
_type: 'event-link',
2020
version,
2121
ownership,
22-
label,
23-
group,
22+
identity,
23+
identityType,
2424
token: tokenId,
2525
createdAt: Date.now(),
2626
createdDate: new Date(),

libs-private/service-logic/services/authkit-demo/client/index.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ export class EmbedToken {
3333

3434
async create(payload: {
3535
version?: string;
36-
label?: string;
37-
group: string;
3836
ttl?: number;
3937
}) {
4038
const secret = this._clientInfo.secret;

libs-private/service-logic/services/authkit-demo/logic/link.api.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,6 @@ export const createEventLinkTokenApi = async (
8282
connectedPlatforms: connectedPlatformsFiltered ?? [],
8383
eventIncToken: linkData?.token,
8484
},
85-
group: linkData?.group,
86-
label: linkData?.label,
8785
environment: isLiveSecret ? 'live' : 'test',
8886
expiresAt: new Date().getTime() + 5 * 1000 * 60,
8987
sessionId,

libs-private/service-logic/services/authkit-demo/useAuthkitDemoService.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ export const useAuthkitDemoService = () => {
1414
);
1515
try {
1616
const token = await embedToken.create({
17-
group: `authkit-demo-group-${uuidv4()
18-
.replace(/-/g, '')
19-
.substring(0, 10)}`,
20-
label: 'Demo connection',
2117
ttl: 2 * 1000 * 60 * 60,
2218
});
2319

libs-private/service-logic/services/event-links/useEventLinksService.ts

Lines changed: 8 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -47,21 +47,21 @@ export const useEventLinksService = (ctx: Context, ownership: Ownership) => {
4747

4848
return {
4949
async create({
50-
label,
51-
group,
50+
identity,
51+
identityType,
5252
ttl = 2 * 1000 * 60 * 60,
5353
environment = 'live',
5454
usageSource,
5555
}: CreateEventLinkPayload): Promise<
5656
BResult<EventLink, 'service', unknown>
5757
> {
5858
const link = await generateEventLinkRecord({
59-
label,
60-
group,
6159
ttl,
6260
ownership,
6361
environment,
6462
usageSource,
63+
identity,
64+
identityType,
6565
});
6666

6767
return await _create<EventLink>('ln', link);
@@ -122,21 +122,6 @@ export const useEventLinksService = (ctx: Context, ownership: Ownership) => {
122122
identity
123123
);
124124

125-
// Get the connection definition by id
126-
const connectionDefinitions =
127-
await makeHttpNetworkCall<ConnectionDefinitions>({
128-
url: `${LIST_CONNECTION_DEFINITIONS_URL}?limit=100&skip=0&active=true`,
129-
method: 'GET',
130-
});
131-
const { data } = matchResultAndHandleHttpError(
132-
connectionDefinitions,
133-
identity
134-
);
135-
136-
const connectionDefinition = data?.rows?.find(
137-
(row) => row?._id === connectionDefinitionId
138-
);
139-
140125
const connection = await makeHttpNetworkCall<ConnectionRecord>({
141126
url: CREATE_CONNECTION_URL,
142127
method: 'POST',
@@ -148,19 +133,9 @@ export const useEventLinksService = (ctx: Context, ownership: Ownership) => {
148133
data: {
149134
active: true,
150135
connectionDefinitionId,
151-
name: authFormData['NAME']
152-
? authFormData['NAME']
153-
: link?.usageSource === 'user-dashboard'
154-
? `${connectionDefinition?.frontend?.spec?.title} sandbox account`
155-
: link?.label,
156136
authFormData,
157-
group: authFormData['NAME']
158-
? `${_.replace(
159-
authFormData['NAME'],
160-
/[^a-zA-Z0-9_]/g,
161-
'-'
162-
).toLowerCase()}-${uuidv4().replace(/-/g, '').substring(0, 10)}`
163-
: link?.group,
137+
identity: link?.identity,
138+
identityType: link?.identityType,
164139
},
165140
});
166141

@@ -244,21 +219,6 @@ export const useEventLinksService = (ctx: Context, ownership: Ownership) => {
244219
identity
245220
);
246221

247-
// Get the connection definition by id
248-
const connectionDefinitions =
249-
await makeHttpNetworkCall<ConnectionDefinitions>({
250-
url: `${LIST_CONNECTION_DEFINITIONS_URL}?limit=100&skip=0&active=true`,
251-
method: 'GET',
252-
});
253-
const { data } = matchResultAndHandleHttpError(
254-
connectionDefinitions,
255-
identity
256-
);
257-
258-
const connectionDefinition = data?.rows?.find(
259-
(row) => row?._id === connectionDefinitionId
260-
);
261-
262222
let secret = headers['x-integrationos-secret'];
263223

264224
if (!secret || secret === 'redacted') {
@@ -283,18 +243,8 @@ export const useEventLinksService = (ctx: Context, ownership: Ownership) => {
283243
},
284244
type,
285245
connectionDefinitionId,
286-
label: formData?.['NAME']
287-
? formData?.['NAME']
288-
: link?.usageSource === 'user-dashboard'
289-
? `${connectionDefinition?.frontend?.spec?.title} sandbox account`
290-
: link?.label,
291-
group: formData?.['NAME']
292-
? `${_.replace(
293-
formData?.['NAME'] as string,
294-
/[^a-zA-Z0-9_]/g,
295-
'-'
296-
).toLowerCase()}-${uuidv4().replace(/-/g, '').substring(0, 10)}`
297-
: link?.group,
246+
identity: link?.identity,
247+
identityType: link?.identityType,
298248
},
299249
});
300250

@@ -349,8 +299,6 @@ export const useEventLinksService = (ctx: Context, ownership: Ownership) => {
349299

350300
// Generate a link record
351301
const link = await generateEventLinkRecord({
352-
label: 'My Connection',
353-
group: `connection-${uuidv4().replace(/-/g, '').substring(0, 10)}`,
354302
ttl: 2 * 1000 * 60 * 60,
355303
ownership: records?.rows?.[0]?.ownership,
356304
environment: headers['x-integrationos-secret'].startsWith('sk_test')
@@ -403,8 +351,6 @@ export const useEventLinksService = (ctx: Context, ownership: Ownership) => {
403351
connectedPlatforms: connectedPlatforms ?? [],
404352
eventIncToken: linkToken?.token,
405353
},
406-
group: linkToken?.group,
407-
label: linkToken?.label,
408354
ttl: 5 * 60 * 1000,
409355
environment: headers['x-integrationos-secret'].startsWith('sk_test')
410356
? 'test'
@@ -470,8 +416,6 @@ export const useEventLinksService = (ctx: Context, ownership: Ownership) => {
470416

471417
// Generate a link record
472418
const link = await generateEventLinkRecord({
473-
label: 'My Connection',
474-
group: `connection-${uuidv4().replace(/-/g, '').substring(0, 10)}`,
475419
ttl: 2 * 1000 * 60 * 60,
476420
ownership: records?.rows?.[0]?.ownership,
477421
environment: 'test',
@@ -522,8 +466,6 @@ export const useEventLinksService = (ctx: Context, ownership: Ownership) => {
522466
connectedPlatforms: connectedPlatforms ?? [],
523467
eventIncToken: linkToken?.token,
524468
},
525-
group: linkToken?.group,
526-
label: linkToken?.label,
527469
ttl: 5 * 60 * 1000,
528470
environment: 'test',
529471
features: settings?.features,

packages/connections/src/apis/link.api.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@ export const createEventLinkTokenApi = async (
8686
connectedPlatforms: connectedPlatformsFiltered ?? [],
8787
eventIncToken: link?.data?.token,
8888
},
89-
group: link?.data?.group,
90-
label: link?.data?.label,
89+
identity: link?.data?.identity,
90+
identityType: link?.data?.identityType,
9191
environment: secret.startsWith('sk_test') ? 'test' : 'live',
9292
expiresAt: new Date().getTime() + 5 * 1000 * 60,
9393
sessionId,

packages/connections/src/client/index.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,9 @@ export class AuthKitToken {
3333
}
3434

3535
async create(payload: {
36-
version?: string;
37-
label?: string;
38-
group: string;
3936
ttl?: number;
37+
identity?: string;
38+
identityType?: "user" | "team" | "organization";
4039
}) {
4140
const secret = this._clientInfo.secret;
4241
const url = this._url;

packages/connections/src/types/index.d.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ export interface EventLink {
1717
_id?: string;
1818
version: string;
1919
ownership: Ownership;
20-
label: string;
21-
group: string;
20+
identity?: string;
21+
identityType?: 'user' | 'team' | 'organization';
2222
token: string;
2323
createdAt: number;
2424
createdDate: Date;
@@ -31,11 +31,11 @@ export interface EventLink {
3131

3232
export type CreateEventLinkPayload = {
3333
version?: string;
34-
label?: string;
35-
group: string;
3634
ttl?: number;
3735
environment?: string;
3836
usageSource?: string;
37+
identity?: string;
38+
identityType?: 'user' | 'team' | 'organization';
3939
};
4040

4141
export interface ConnectionDefinition {
@@ -155,8 +155,6 @@ export interface EmbedTokenRecord {
155155
connectedPlatforms: Platform[];
156156
eventIncToken: string;
157157
};
158-
label: string;
159-
group: string;
160158
createdAt: number;
161159
createdDate: Date;
162160
updatedAt?: number;

packages/types/embed-tokens.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ export interface EmbedTokensPayload {
2424
connectedPlatforms: Platform[];
2525
eventIncToken: string;
2626
};
27-
group: string;
28-
label: string;
27+
identity?: string;
28+
identityType?: 'user' | 'team' | 'organization';
2929
environment: string;
3030
ttl: number;
3131
sessionId: string;
@@ -38,8 +38,8 @@ export interface EmbedTokenRecord {
3838
eventIncToken: string;
3939
};
4040
features?: Feature[];
41-
label: string;
42-
group: string;
41+
identity?: string;
42+
identityType?: 'user' | 'team' | 'organization';
4343
createdAt: number;
4444
createdDate: Date;
4545
updatedAt?: number;

packages/types/links.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,19 @@ export interface AuthFormData {
66

77
export type CreateEventLinkPayload = {
88
version?: string;
9-
label?: string;
10-
group: string;
119
ttl?: number;
1210
environment?: string;
1311
usageSource?: string;
12+
identity?: string;
13+
identityType?: 'user' | 'team' | 'organization';
1414
};
1515

1616
export interface EventLink {
1717
_id?: string;
1818
version: string;
1919
ownership: Ownership;
20-
label: string;
21-
group: string;
20+
identity?: string;
21+
identityType?: 'user' | 'team' | 'organization';
2222
token: string;
2323
createdAt: number;
2424
createdDate: Date;

0 commit comments

Comments
 (0)