Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentation (Tab and Space) #9

Closed
karbowiak opened this issue Jun 22, 2015 · 5 comments
Closed

Indentation (Tab and Space) #9

karbowiak opened this issue Jun 22, 2015 · 5 comments
Labels

Comments

@karbowiak
Copy link

Hi there!
Just started using it, and it's awesome for what i'm doing.

However, the indentation is done with tabs, any chance of adding a config that will allow me (and others) to switch it to spaces? :)

@marcj
Copy link
Contributor

marcj commented Jun 22, 2015

+1

@gossi
Copy link
Member

gossi commented Jun 22, 2015

Nope, spaces suck!

Yet, I've created the gossi/php-code-formatter project to address this.

@gossi gossi added the wontfix label Dec 28, 2015
@gossi gossi closed this as completed Dec 29, 2015
@marcj
Copy link
Contributor

marcj commented Dec 29, 2015

Oh, well, then it looks like it's time for a fork which addresses the need of the wider PHP community that use spaces. :/

@gossi
Copy link
Member

gossi commented Jan 1, 2016

Nope. That's the wrong way.

There are no real code formatter packages available, that's why I created one. Although it has very limited functionality at the moment. Yet what it does, it supports code style profiles. The right way would be to strengthen the code formatter library and make it a depdency on the code-generator project. For code generation pass the profile used for formatting to the generator and that's the way to go.

@gossi
Copy link
Member

gossi commented Jan 1, 2016

Refer to #23 to discuss ideas there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants