Skip to content

Commit 949d919

Browse files
authored
Merge pull request #318 from phpmetrics/fix-317
Fix #317: Only consolidate class metrics that groups Classes and Traits to calculate sums and averages.
2 parents 7b67c75 + a1f1ca7 commit 949d919

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/Hal/Metric/Consolidated.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ class Consolidated
3636
*/
3737
public function __construct(Metrics $metrics)
3838
{
39+
$classMetrics = [];
40+
3941
// grouping results
4042
$classes = [];
4143
$functions = [];
@@ -46,6 +48,7 @@ public function __construct(Metrics $metrics)
4648
$classItem = get_class($item);
4749
if (ClassMetric::class === $classItem) {
4850
$classes[] = $item->all();
51+
$classMetrics = $item;
4952
} elseif (InterfaceMetric::class === $classItem) {
5053
$nbInterfaces++;
5154
} elseif (FunctionMetric::class === $classItem) {
@@ -82,7 +85,7 @@ public function __construct(Metrics $metrics)
8285
'mi' => [],
8386
];
8487

85-
foreach ($metrics->all() as $key => $item) {
88+
foreach ($classMetrics as $key => $item) {
8689
$sum->loc += $item->get('loc');
8790
$sum->lloc += $item->get('lloc');
8891
$sum->cloc += $item->get('cloc');

0 commit comments

Comments
 (0)