Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building when package is not in the root directory #84

Closed
asgrim opened this issue Nov 7, 2024 · 5 comments · Fixed by #115
Closed

Support building when package is not in the root directory #84

asgrim opened this issue Nov 7, 2024 · 5 comments · Fixed by #115
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@asgrim
Copy link
Collaborator

asgrim commented Nov 7, 2024

From @zeriyoshi - original proposal in #82

Add extension-src directive to the php-ext section in composer.json.

This enables support for patterns where extension source code is not located in the project root, which is commonly seen in third-party extensions.

https://github.com/protocolbuffers/protobuf/tree/main/php/ext/google/protobuf

{
    "name": "google/protobuf",
    "type": "php-ext",
    "description": "protocolbuffers php extension",
    "php-ext": {
        "extension-name": "protobuf",
        "extension-src": "php/ext/google/protobuf"
    }
}

Investigate options, check this makes sense and is clear. Documentation would be needed, and upstream Composer schema support.

@asgrim asgrim added the enhancement New feature or request label Nov 7, 2024
@asgrim asgrim self-assigned this Nov 7, 2024
@asgrim
Copy link
Collaborator Author

asgrim commented Nov 7, 2024

I will revisit this after #83 is merged

@macintoshplus
Copy link

macintoshplus commented Nov 19, 2024

@asgrim This option can specify the name of the extension DLL?

Other automated scripts already use the zip attached on the GitHub release to install an extension automatically. It's hard to change the dll name into the zip archive without breaking something.

@asgrim
Copy link
Collaborator Author

asgrim commented Nov 19, 2024

@asgrim This option can specify the name of the extension DLL?

Other automated scripts already use the zip attached on the GitHub release to install an extension automatically. It's hard to change the dll name into the zip archive without breaking something.

This is an entirely separate issue

@asgrim
Copy link
Collaborator Author

asgrim commented Nov 19, 2024

@zeriyoshi I gave this some thought, I think build-path may be a better name for this.

ThePHPF/pie-design#28

If there is no further feedback, please leave it with me, I have a PR updated and also will send a patch upstream to Composer.

@zeriyoshi
Copy link
Contributor

Sorry, I missed this one. I don't think it's a problem.

@asgrim asgrim added this to the 0.3.0 milestone Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants