Download Git submodules #160
Draft
+287
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @alcaeus |
Full log of failed build |
|
You can't just take the last commit from the main branch, you need the exact commit that was committed. Maybe we could specify the commit in the |
|
It seems you can provide |
damienfern
reviewed
Dec 24, 2024
| $downloadedPackage->extractedSourcePath, | ||
| )); | ||
|
|
||
| $git = GitBinaryPath::fromGitBinaryPath('/opt/homebrew/bin/git'); |
There was a problem hiding this comment.
This path is specific to macOS package manager, it won't work on other systems.
I'm not even sure it is needed to specify git path as it should be in $PATH of the user
There was a problem hiding this comment.
Ah yes indeed, it was for test purposes to validate the implementation. Thanks for spotting it 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #39
As stated in the issue, the .git isn't present in the ZIP archived downloaded from Github. This makes not possible to use
git submodules update....Here is the approach I propose: manually parse the .gitmodules (which isn't a complicated format so it works well), then recursively go through those modules and
git cloneeach of them.Try this out with :
bin/pie build mongodb/mongodb-extension. Note that you may still have an error with this particular extension, but it is not related to this dev. But that's the only extension I found for now that uses submodules 😄It would be nice to update
asgrim/example-pie-extensionto add a.gitmodulesto test this in the behavioral tests.