Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup on aisle vendor #157

Open
asgrim opened this issue Dec 17, 2024 · 4 comments
Open

Cleanup on aisle vendor #157

asgrim opened this issue Dec 17, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@asgrim
Copy link
Collaborator

asgrim commented Dec 17, 2024

After discussing with @derickr a bit, everything in the PIE working directory vendor except vendor/composer/installed.json is mostly just taking up space. It isn't used as a cache for subsequent (re)installs, so it is just taking up space.

Apparently Datadog ext is very large, so this could become problematic if we don't clean up. I imagine some kind of post install cleanup step can run that removes vendor/* (except vendor/composer), could work, although I need to investigate viability and impact.

@asgrim asgrim added the enhancement New feature or request label Dec 17, 2024
@remicollet
Copy link
Member

remicollet commented Dec 24, 2024

Related to this, what is the goal of building in user home directory ?
Using any temporary directory will be fine (and usually temp have auto cleanup feature)

I understand composer use ~/.composer for global Installation, commands in ~/.composer/vendor/bin are usable

@asgrim
Copy link
Collaborator Author

asgrim commented Dec 24, 2024

Related to this, what is the goal of building in user home directory ?

See ThePHPF/pie-design#26 - TLDR, it will help us to auto-upgrade extension in the future, e.g. just running pie update will be able to update all the currently PIE-sourced extensions

@remicollet
Copy link
Member

I understand the need to store some metadata (pie.json), but not the build

@asgrim
Copy link
Collaborator Author

asgrim commented Dec 24, 2024

I understand the need to store some metadata (pie.json), but not the build

That is just how Composer works - you give it the path to composer.json (although we call it pie.json to avoid confusion) and it does the lock/vendor stuff itself. The key files we actually want to keep is pie.json, pie.lock, but we also need vendor/composer/installed.json, since the latter file is the one that actually has the build metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants