Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIE installable in a Dockerfile? #137

Closed
asgrim opened this issue Nov 25, 2024 · 0 comments · Fixed by #122
Closed

PIE installable in a Dockerfile? #137

asgrim opened this issue Nov 25, 2024 · 0 comments · Fixed by #122
Assignees
Labels
question Further information is requested

Comments

@asgrim
Copy link
Collaborator

asgrim commented Nov 25, 2024

Relates to existing PR #122

Should PIE be installable in a Dockerfile?

COPY --from=ghcr.io/php/pie:latest /pie /usr/bin/pie

Points to note:

  • This is NOT an executable image (i.e. you would not be able to run docker run --rm ghcr.io/php/pie:latest) - this is only publishing the PHAR but contained within the Dockerfile.
  • Alternate approaches would be using ADD , for example (note; untested) ADD https://github.com/php/pie/releases/latest/download/pie.phar /usr/bin/pie
  • There is an open question about attestation; how to guarantee the image. One approach could be to use gh attestation verify (recent example for the PHAR itself in Add build provenance attestation to the release workflow #128 )

Currently the only supported distribution mechanism is downloading the PHAR from the https://github.com/php/pie/releases page. Other distribution mechanisms should be carefully evaluated on a case-by-case basis.

@asgrim asgrim added question Further information is requested maintainer feedback needed Needs details or feedback to be added by maintainers labels Nov 25, 2024
@asgrim asgrim self-assigned this Dec 4, 2024
@asgrim asgrim removed the maintainer feedback needed Needs details or feedback to be added by maintainers label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant